Due to the merge of both of the following, the soft limit no longer works if multiple instances are on the page, this is due to 2910421 changing the ID of the facet when multiple instances exist.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

b_sharpe created an issue. See original summary.

b_sharpe’s picture

Status: Active » Needs review
FileSize
1.4 KB

This patch cleans up the code so that it has a known facet id to use throughout the function, though I would think this should be refactored in general to NOT change the id and maybe create a new data attribute for multiple instances as I can imagine this conflict may occur elsewhere.

borisson_’s picture

Status: Needs review » Postponed (maintainer needs more info)
FileSize
219.86 KB

I can't reproduce this.

Looks like this just works.

b_sharpe’s picture

Status: Postponed (maintainer needs more info) » Needs review

It's referring to multiple instances of the SAME facet on the page (in my case due to mobile layout being radically different).

See #2910421: If same facet is used more than once on a page - soft limit does not work correctly for more info

borisson_’s picture

Status: Needs review » Reviewed & tested by the community

Aha, thanks for explaining further. I tested the patch and it looks solid. Great work!

dcam’s picture

RTBC +1

I just ran into this issue too because of a duplicate block in an off-canvas menu. The patch resolved the problem.

  • borisson_ committed 345525d on 8.x-1.x authored by b_sharpe
    Issue #2927283 by b_sharpe: Softlimit doesn't work if multiple instances...
borisson_’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.