Fix core search tests with postgres [#2693861]

Comment	File	Size	Author
#2	2693861-2.patch	849 bytes	marthinal

Comment #1

24 March 2016 at 19:54

borisson_ created an issue. See original summary.

Log in or register to post comments

Comment #2

marthinal CreditAttribution: marthinal commented 19 April 2016 at 16:56

Status:	Active	» Needs review
Related issues:		+#2057693: PostgreSQL orderBy method adds fields it doesn't need to, leading to fatal errors when the result is used as an insert subquery

File	Size
2693861-2.patch	849 bytes

Thanks for reporting. OK! let's try to fix the problem.

Log in or register to post comments

Comment #3

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ commented 20 April 2016 at 09:08

Status:

Needs review

» Fixed

Tests are green, thanks for the patch. Great work Jose!

Log in or register to post comments

Comment #4

20 April 2016 at 09:08

borisson_ committed 5e361b5 on 8.x-1.x authored by marthinal

Issue #2693861 by marthinal: Fix core search tests with postgres

Log in or register to post comments

Comment #5

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ commented 20 April 2016 at 09:24

Looks like the tests still fail but I don't think we can fix that very easy: https://www.drupal.org/pift-ci-job/255333

See the error message:

exception: [Uncaught exception] Line 486 of core/includes/install.core.inc:
Drupal\Core\Installer\Exception\AlreadyInstalledException:
To start over, you must empty your existing database and copy default.settings.php over settings.php.
To upgrade an existing installation, proceed to the update script.

I think we can leave this as fixed and we should open an issue for the bots?