I've just updated to the current (2016-Dec-19) version of 7.x-1.x-dev

If I try visiting a bookmarked page that has several facets already selected, the warning message "Theme hook current_search_accessible_markup not found." is shown in the "Recent log messages" report.

The recent change that mentions that hook is https://www.drupal.org/node/1942922, so it may be related.

CommentFileSizeAuthor
#3 facetapi-7.x-1.x-2866117-3-register-theme-hook.patch618 bytesdonquixote
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

davidhk created an issue. See original summary.

donquixote’s picture

donquixote CreditAttribution: donquixote as a volunteer commented

Yes, the theme callback theme_current_search_accessible_markup() and the call in theme_current_search_link_active() were introduced without registering this hook in current_search_theme(). This is a bug.

Suggested fix:

@@ -105,6 +105,11 @@ function current_search_theme() {
       'render element' => 'element',
       'file' => 'current_search.theme.inc',
     ),
+    /* @see theme_current_search_accessible_markup() */
+    'current_search_accessible_markup' => array(
+      'arguments' => array('text' => NULL, 'active' => FALSE),
+      'file' => 'current_search.theme.inc',
+    ),
   );
 }
donquixote’s picture

donquixote CreditAttribution: donquixote as a volunteer commented
Status: Active » Needs review
FileSize
facetapi-7.x-1.x-2866117-3-register-theme-hook.patch618 bytes
davidhk’s picture

davidhk CreditAttribution: davidhk commented
Status: Needs review » Reviewed & tested by the community

Thanks @donquixote, I made the change suggested above and there are no more warning messages.

Yazzbe’s picture

Yazzbe CreditAttribution: Yazzbe commented

tx. that fixed it.
no more errors in the log.

anrikun’s picture

anrikun CreditAttribution: anrikun commented

+1 RTBC

cmseasy’s picture

cmseasy CreditAttribution: cmseasy commented

+1 please commit

eugene.ilyin credited eugene.ilyin.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

Small but important fix. Committed.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.