There is a greater than where there should be a less than in the caching code in facebook_pull.module on line 215 and 256.

Currently they say:
if (!$cache || $cache->created + FACEBOOK_PULL_CACHETIME > time()) {
They should be:
if (!$cache || $cache->created + FACEBOOK_PULL_CACHETIME < time() ) {

Currently it only connects to Facebook if the last call was less than 20 minutes ago or if you clear all caches.

CommentFileSizeAuthor
#1 2395681-1.patch1.14 KBSteven Merrill
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Steven Merrill’s picture

Steven Merrill CreditAttribution: Steven Merrill commented
FileSize
2395681-1.patch1.14 KB

A patch is attached.

I have also converted time() to REQUEST_TIME, which is a best practice.

daveferrara1’s picture

daveferrara1 CreditAttribution: daveferrara1 commented
Status: Active » Closed (fixed)

Issue #2395681 by Steven Merrill: Caching doesn't work correctly