I think it's not a real bug, but perhaps a proposal.

Is there any reason that a whitespace (blank) is included in the generated code?
e.g.: <span class="element-invisible"> </span>
(from extlink.js, line 142 and/or 145)

Because: The output looks a bit "fuzzy" when the whitespace is in the code. Especially, when the link is underlined or is followed by a punctuation mark.

I removed the blank and didn't ran into issues so far.

CommentFileSizeAuthor
#4 extlink_extra-space-span_2733451_4.patch5.89 KBmeramo
#4 extlink.jpg35.04 KBmeramo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

andres_de created an issue. See original summary.

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
Status: Active » Closed (works as designed)

I believe it could either be used for hover text or for accessibility for screen readers?

Check extlink.module 

'extLabel'       => Safemarkup::checkPlain($config->get('extlink_label', t('(link is external)'))),
'mailtoLabel'    => Safemarkup::checkPlain($config->get('extlink_mailto_label', t('(link sends e-mail)'))),
andres_de’s picture

andres_de CreditAttribution: andres_de commented

The span code itself with its classes is useful, no doubt.

The problem with the "unclean" html output occurs when you use css border-bottom for highlightening links in texts. With normal text-decoration:underline the link looks fine.

The question is wether we can eliminate the blank in the span code without breaking functionality.

meramo’s picture

meramo CreditAttribution: meramo at Bright Solutions GmbH commented
FileSize
extlink.jpg35.04 KB
extlink_extra-space-span_2733451_4.patch5.89 KB

I can say this is really annoying to have this extra blank space, which is very visible in all cases. Maybe I just didn't get how to configure the module to not have this blank (in this case my apologies), but it always produces output like this on the screenshot:
Extlink

I tried to remove the space and tested with all options, including having an icon for mailto and external links, and all the time it worked fine. So although this may not be a proper patch, attaching here just in case someone has the same issue and wants a quick fix