Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
I just uploaded the latest release 6.x-1.13 and none of my external links opened in a new window anymore. I went to the settings page and checked everything and re-saved the settings and even tried adding a pattern and still no luck. I uploaded the previous version and they worked again..
just an FYI.
Paul
Comment | File | Size | Author |
---|---|---|---|
#8 | extlink6-fixed.patch | 317 bytes | nowrap |
#6 | extlink6-fix.patch | 339 bytes | elachlan |
Comments
Comment #1
akalata CreditAttribution: akalata commentedSame issue here. Clearing all caches does not help either.
Comment #2
roball CreditAttribution: roball commentedCan also confirm that 6.x-1.13 does not work. Also the icons are no longer displayed. Downgrading back to 6.x-1.11 is the current solution to get it working again.
It seems the problem is this one: #2054433: hook_page_build() used - Drupal 6 does not have this hook
Comment #3
elachlan CreditAttribution: elachlan commentedDuplicate of above issue. Issue is fixed.
Comment #4
roball CreditAttribution: roball commented6.x-1.14 still does not work :-(
I would suggest to test a version before tagging it as a release.
Comment #5
dpatte CreditAttribution: dpatte commentedlikewise broken
Comment #6
elachlan CreditAttribution: elachlan commentedI think it might be this. I don't have my development environment setup yet, due a reformat. Can someone please test it?
Comment #7
nowrap CreditAttribution: nowrap commentedThe provided patch fixes the original TypeError concerning the extlink property within the Drupal.behaviors.
But there is a typo in the patch causing a syntax error.
Comment #8
nowrap CreditAttribution: nowrap commentedupdate:
i created and tested a new patch
Comment #9
elachlan CreditAttribution: elachlan commentedDoes extlink work again with the patch?
Comment #10
sdsheridanYup, it does. I just tested it. It was failing on the javascript, and messing up a bunch of other js in the process.
Comment #11
quicksketchYep, definitely needs to happen. In D6 we don't have a .attach() method in behaviors. Don't worry too much about the mess @elachlan. It's a learning experience. :) Though if you can handle rolling the new version that would be great.
Comment #12
giacy86 CreditAttribution: giacy86 commentedSame here. In 6.14 also doesn't work the expandables link!
Comment #13
elachlan CreditAttribution: elachlan commentedNew Release!
Thanks for the help in the debugging. Sorry for the inconvenience.
https://drupal.org/node/2056951
Comment #14
elachlan CreditAttribution: elachlan commented