Hello,

I just uploaded the latest release 6.x-1.13 and none of my external links opened in a new window anymore. I went to the settings page and checked everything and re-saved the settings and even tried adding a pattern and still no luck. I uploaded the previous version and they worked again..

just an FYI.

Paul

CommentFileSizeAuthor
#8 extlink6-fixed.patch317 bytesnowrap
#6 extlink6-fix.patch339 byteselachlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

akalata’s picture

akalata CreditAttribution: akalata commented

Same issue here. Clearing all caches does not help either.

roball’s picture

roball CreditAttribution: roball commented
Title: 6.x-1.13 broken » 6.x-1.13 is broken!
Priority: Normal » Critical

Can also confirm that 6.x-1.13 does not work. Also the icons are no longer displayed. Downgrading back to 6.x-1.11 is the current solution to get it working again.

It seems the problem is this one: #2054433: hook_page_build() used - Drupal 6 does not have this hook

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Active » Closed (duplicate)

Duplicate of above issue. Issue is fixed.

roball’s picture

roball CreditAttribution: roball commented
Title: 6.x-1.13 is broken! » Both External Links 6.x-1.14 and 6.x-1.13 releases are broken!
Version: 6.x-1.13 » 6.x-1.14
Status: Closed (duplicate) » Active

6.x-1.14 still does not work :-(

I would suggest to test a version before tagging it as a release.

dpatte’s picture

dpatte CreditAttribution: dpatte commented

likewise broken

elachlan’s picture

elachlan CreditAttribution: elachlan commented
FileSize
extlink6-fix.patch339 bytes

I think it might be this. I don't have my development environment setup yet, due a reformat. Can someone please test it?

nowrap’s picture

nowrap CreditAttribution: nowrap commented

The provided patch fixes the original TypeError concerning the extlink property within the Drupal.behaviors.
But there is a typo in the patch causing a syntax error.

nowrap’s picture

nowrap CreditAttribution: nowrap commented
FileSize
extlink6-fixed.patch317 bytes

update:
i created and tested a new patch

elachlan’s picture

elachlan CreditAttribution: elachlan commented

Does extlink work again with the patch?

sdsheridan’s picture

sdsheridan
he/him/his
CreditAttribution: sdsheridan commented

Yup, it does. I just tested it. It was failing on the javascript, and messing up a bunch of other js in the process.

quicksketch’s picture

quicksketch
he/him
CreditAttribution: quicksketch commented
Status: Active » Reviewed & tested by the community

Yep, definitely needs to happen. In D6 we don't have a .attach() method in behaviors. Don't worry too much about the mess @elachlan. It's a learning experience. :) Though if you can handle rolling the new version that would be great.

giacy86’s picture

giacy86 CreditAttribution: giacy86 commented

Same here. In 6.14 also doesn't work the expandables link!

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Reviewed & tested by the community » Fixed

New Release!

Thanks for the help in the debugging. Sorry for the inconvenience.

https://drupal.org/node/2056951

elachlan’s picture

elachlan CreditAttribution: elachlan commented
Status: Fixed » Closed (fixed)