When configuring the the module under `admin/structure/external-entity-types/manage/{my_entity}` you can edit the endpoint url. But having a trailing slash will result in an error, since the guzzle url will have an additional slash hardcoded...

Solution

Enforce having or not having a trailing slash at this very field. And handle config storage accordingly.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tassilogroeper created an issue. See original summary.

tassilogroeper’s picture

Status: Active » Needs review
FileSize
3.07 KB

- I took the liberty to change to array short syntax.
- Change the endpoint input to url. Added description hinting to the trailing slash.
- change the `default_limit` input to number. Set minimal input number to zero.

larskhansen’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me.

rp7’s picture

Version: 8.x-1.x-dev » 8.x-2.x-dev
FileSize
714 bytes

Thank you for the patch.

The 2.x version of this module was introduced a few weeks ago: #2995140: External Entities 2.x
This fixes the short array syntax & the default_limit field type (number).
This doesn't fix the slash issue however. Attached patch solely does this.

  • rp7 committed eacc8b4 on 8.x-2.x
    Issue #2878806 by tassilogroeper, rp7: Force endpoint URL format with no...
rp7’s picture

Status: Reviewed & tested by the community » Fixed

Patch was committed & credited you tassilogroeper, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.