Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.I noticed that the module was not working for me (drupal 6.14/15, chrome 4.something, firefox 3.6). I'm using wysiwyg with tinymce, all filters active and the following tags allowed:
-
-
-
. The site is unthemed (zen classic) and the link was added after activating this module. I did not specify a target when creating the link. What am i doing wrong?
Comments
Comment #1
mcrittenden CreditAttribution: mcrittenden commentedIs the code being loaded? Try using Firebug or Web Developer Toolbar to see if external.js is being loaded.
Comment #2
whatdoesitwant CreditAttribution: whatdoesitwant commentedYes, external.js is being loaded.
In a seemingly unrelated issue i have tracked down an unidentified exception that was playing havok with my sites to this module:
unrecognized expression [@href^=http]. It is related to a change in jquery 1.3.As described at #358082: jQuery 1.3 in Drupal 6.x and numerous other topics Xpath support has been dropped from jquery. This means that you have a deprecated statement at line 4 of external.js. Therefore External New Tab will apparently break most sites running an up to date version of jquery (install jquery_update to check). Please search for "remove @ from selectors" on drupal.org.
Apparently you just have to remove the @-selector. Check out #412126: Remove @ from selectors for example code. Unfortunately I still don't know how to do a proper patch (i know, i know), so I hope you will follow this up.
Moving this issue up to critical. Changed the title.
Comment #3
mcrittenden CreditAttribution: mcrittenden commentedWill commit a fix ASAP. Thanks for the pointers and all the detailed info.
Comment #4
mcrittenden CreditAttribution: mcrittenden commentedCommitted to 6.x-1.6. See http://drupal.org/node/676552