Inconsistent type used for $urls in hook_expire_cache()

On top of that, it converts the URLs to an absolute path, whereas the documentation shows:

 *   Example of array (when base url include option is disabled):
 *   array(
 *     'node/1' => 'node/1',
 *     'news' => 'news',
 *   );

This patch converts them to relative paths, though I still wonder if that is the correct approach to take.

I'm starting to think that the base_path() should not be added to the front of the paths, that it should be stripped off the front. What do you think?

This removes the base_path().

The question is - should it use url() at all, or should it just manually combine $path['path'] and $url['query']? The $language string throws some confusion into this..

Indeed URL displays empty in debugLog and this makes the Expire module unusable when used in conjunction with varnish module as in configuration it is stated "Enabling this setting (Include base URL in expires) when Varnish or Acquia Purge modules are used as a cache backend is *not* recommended."

Of course the change suggested by Damien's patch at #6 could be done inside hook_expire_cache of the Varnish module but in such case Expire will continue to complain throwing "strpos() expects parameter 1 to be string, array given". So I think #6 gives the right place to patch.

As for the $language string (see #7), I think we need to keep it in case sites have more than one language activated. From the url() API documentation "$options['language'] is used to look up the alias for the URL".

How about this instead?

Bit confused why we're dropping the absolute part though?

This patch has been around for over 4 years and needs review: https://www.drupal.org/project/expire/issues/2549647#comment-10282873

Should be consolidated.

Agreed, closing this as a duplicate. I don't agree with the patch in that issue though ... It absolutely should take query strings and language into account. I'll open it up for discussion with an altered patch.