Overview

CI is now using 2.1.22 of phpstan which yields some new issues in HEAD

Proposed resolution

Fix em!

User interface changes

Issue fork experience_builder-3539676

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !1412

dpi’s picture

dpi
Location Perth, Australia
commented

Mind giving the change in https://github.com/mglaman/phpstan-drupal/pull/903/files a shot

dpi’s picture

dpi
Location Perth, Australia
commented 
"require-dev": {
        "mglaman/phpstan-drupal": "dev-narrow-id-return-by-isnew--only-existing as 2.9999.9999"
}
"repositories": [
    {
        "type": "git",
        "url": "git@github.com:dpi/phpstan-drupal.git"
    }
],
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

We don't use mglaman/phpstan-drupal apparently, I thought we did.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented

re #5 but is in mglaman/phpstan-drupal composer.lock for CI composer job https://git.drupalcode.org/project/experience_builder/-/jobs/6109992/art...

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: Unassigned » mglaman

@mglaman, can you take a look?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

Yeah discussed via Slack, realized it was an issue with missing narrowed types, dpi made fixes and a new phpstan-drupal release rolling soon

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

https://github.com/mglaman/phpstan-drupal/releases/tag/2.0.9 this should fix if we can update

tedbow opened merge request !1413

  • tedbow committed 84b30798 on 1.x 
    Issue #3539676: Fix phpstan in HEAD from phpstan update to 2.1.22
tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Assigned: mglaman » Unassigned
Status: Active » Fixed

larowlan closed merge request !1412

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.