Overview

The overlay appears in an incorrect position frequently for some components. See for example, these logo cards here, I tested this multiple times and most times the position is displayed in an incorrect position. This is a critical UX problem because not being able to click from a preview, or see where layers are within the preview makes it hard to work with content.

Proposed resolution

I think @larowlan makes a good suggestion here https://www.drupal.org/project/experience_builder/issues/3533537#comment-16199128 as a starting point.

I think that the offset calculation for slots and components is perhaps incorrect as a result of either attempting to calculate the position before the astro-island's have hydrated or because the content isn't yet rendered at the point that the offset is being calculated.

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jessebaker created an issue. See original summary.

jessebaker’s picture

Assigned: jessebaker » Unassigned
Status: Active » Needs review

bnjmnm made their first commit to this issue’s fork.

bnjmnm’s picture

Status: Needs review » Needs work

I left two more comments on the MR that might be asking for more than two changes. None of them are functionality impacting, though, so I'm happy to approve the MR code-wise and once the doc additions and (possible) formatting adjustments this can probably go in.

  • jessebaker committed 3ae4235b on 1.x
    Issue #3538727 by jessebaker, bnjmnm: Position of some components is...
jessebaker’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.