Overview

This sort of message should also link to where it is possible to make the changes to remedy it.

Proposed resolution

User interface changes

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

bnjmnm created an issue. See original summary.

larowlan’s picture

Component: … to be triaged » Page builder
bnjmnm’s picture

Assigned: bnjmnm » Unassigned
Status: Active » Needs review

Setting to NR. e2e fails seem to be random / intermittent / unrelated. Will continue to stop back to rerun until green, but review should be fine unless you see publish-validation.cy.js failing.

hooroomoo’s picture

Status: Needs review » Needs work
wim leers’s picture

This seems critical for usability and accessibility?! 😄 Love it!

(A GIF showing it in action would be nice too. 😇)

hooroomoo’s picture

StatusFileSize
new152.49 KB

@wim-leers

Steps to reproduce the bug I mentioned in https://git.drupalcode.org/project/experience_builder/-/merge_requests/1.... I reproduced this on MR!1360

1. Create the code component below. Text and link required prop.
2. Click add to components.
3. Add two instances of the component on the page (xb_page).
4. Edit the url prop to be empty on both of the instances that are on the page.
5. Publish the xb_page that the 2 components are on.
6. This is the error message i get:
screenshot

uuid: 6c21e124-4d78-408b-8896-1a26a28bcbdc
langcode: en
status: true
dependencies: {  }
machineName: c1
name: c1
required:
  - text
  - url
props:
  text:
    title: text
    type: string
    examples:
      - hello
  url:
    title: url
    type: string
    examples:
      - 'https://www.hello.com'
    format: uri
slots: {  }
js:
  original: |
    // See https://project.pages.drupalcode.org/experience_builder/ for documentation on how to build a code component

    const Component = ({
      text,
      url,
    }) => {
      return (
        <div className="text-3xl">
          {text}
        <br></br>
          {url}
        </div>
      );
    };

    export default Component;
  compiled: |
    // See https://project.pages.drupalcode.org/experience_builder/ for documentation on how to build a code component
    import { jsx as _jsx, jsxs as _jsxs } from "react/jsx-runtime";
    const Component = ({ text, url })=>{
        return /*#__PURE__*/ _jsxs("div", {
            className: "text-3xl",
            children: [
                text,
                /*#__PURE__*/ _jsx("br", {}),
                url
            ]
        });
    };
    export default Component;
css:
  original: ''
  compiled: ''
bnjmnm’s picture

Status: Needs work » Needs review

FB Addressed, but in a new MR 3537146-error-links-cleaner-diff

  • hooroomoo committed 28758b56 on 1.x authored by bnjmnm
    Issue #3537146 by bnjmnm, hooroomoo, larowlan: Link Publish errors to...
hooroomoo’s picture

Status: Needs review » Needs work

Merged but assigning back to @bnjmnm to add screenshots/gif

hooroomoo’s picture

Assigned: Unassigned » bnjmnm
mayur-sose’s picture

Error messages now correctly link to the component instance causing the error in the new tab.

bnjmnm’s picture

Assigned: bnjmnm » Unassigned
Status: Needs work » Fixed

Screen recording in #14 addresses the need that was keeping this at "needs work" status.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.