The loading animation on the "Review changes" button is distracting when editing content because it results in the color of the button changing and all of the buttons on the top right moving around. The loading animation there seems completely unnecessary, we should just load the changes without showing a loading state.
Remove loading animation from the "Review changes" button.
| Comment | File | Size | Author |
|---|---|---|---|
| #9 | final-review.mp4 | 893.99 KB | libbna |
| #5 | after.mp4 | 1.04 MB | libbna |
| #5 | before.mp4 | 390.37 KB | libbna |
| CleanShot 2025-07-11 at 22.09.28.gif | 668.13 KB | lauriii |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #4
libbna commentedI will review this.
Comment #5
libbna commentedI have reviewed MR #3, and it looks good to me.
I've also attached screen recordings showing the before and after states to demonstrate the expected outcome.
I am updating the issue status to NR so that the maintainer can review it and provide feedback.
Comment #6
jessebaker commentedComment #7
jessebaker commented@libbna - I see you already reviewed/tested this earlier.
My bad, I didn't correctly assign the ticket to me when I began first thing this morning so you tested before I was ready! I've had to refactor the code since you tested which unfortunately probably invalidates the test you did. If you have an opportunity to re-test, that would be hugely appreciated.
Comment #8
libbna commentedHi @jessebaker sure, no problem. I will re-test it :)
Comment #9
libbna commentedI’ve re-tested the changes, and everything looks good to me (I don't see any loading animation on the review changes button). I had already uploaded the "before" screen recording earlier — now uploading the "after" screen recording again as proof that everything is working as expected.
Comment #10
lauriiiNice one! Tested this manually as well and it works great.
Comment #13
hooroomoo