Overview
None of the existing single directory components should be provided to users as they are currently only used for testing purposes.
Proposed resolution
Move any single directory components from the main experience builder module into a testing module and remove any that are not used for testing.
User interface changes
Issue fork experience_builder-3535447
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
justafishComment #3
lauriiiComment #6
nagwani commentedComment #7
thoward216 commentedComment #8
thoward216 commentedUpdating issue summary.
Comment #9
effulgentsia commentedComment #10
thoward216 commentedComment #11
effulgentsia commentedNote to reviewers: please review this as normal, but once this gets to RTBC, instead of merging it, please set it to Postponed. There's a few MRs in the queue that we'll want to merge in ahead of this one rather than requiring tedious merging/rebasing of them.
Comment #12
thoward216 commentedMoving back to needs work as rebased with latest 0.x and resolved conflicts but there are now some failing tests.
Comment #13
thoward216 commentedComment #14
wim leersI'm surprised by how fast @thoward216 got this done, and by how easy the diff was to review! 😮🥳
It's very gratifying to see that the hashes remained unchanged — that's a great piece of validation for
ComponentInputsEvolutionTest(added in #3523841: Versioned Component config entities (SDC, JS: prop_field_definitions, block: default_setting, all: slots for fallback) + component instances refer to versions ⇒ less data to store per XB field row), because it proves that one use case that @catch was very worried about (ohai!) truly is simple! 👍 (Insofar this is ever simple, of course.)Also: thank you for the guidance comments such as https://git.drupalcode.org/project/experience_builder/-/merge_requests/1... — those are super helpful! 🙏
Per @effulgentsia at #11:
Comment #15
wim leersComment #16
effulgentsia commentedI think everything I had in mind when I wrote #11 landed already, so setting this to RTBC, but please re-postpone it if there are other tedious-to-rebase MRs we're still wanting to get in before this one.
Comment #17
wim leers#3503412: Allow Content Author to set site's homepage from navigator is in. That's the last big one.
Merged in upstream, this should still be green 🤞
Comment #19
wim leersFeels like a major milestone to say goodbye to these SDCs that we've all interacted with a million times — but they're not gone, they're just boxed up now 🤓