Closed (fixed)
Project:
Experience Builder
Version:
0.x-dev
Component:
Internal HTTP API
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
23 Jun 2025 at 21:33 UTC
Updated:
8 Jul 2025 at 19:49 UTC
Jump to comment: Most recent
Comments
Comment #2
penyaskitoComment #3
balintbrewsI just realized that I meant to open the issue for
api.config.get, that's where I originally discovered the problem. I haven't testedapi.config.auto-save.get, so let's be sure to check that, too.Comment #4
wim leersThat shouldn't be the case:
AFAICT this is simply questioning #3508694: Permissions for XB config entity types's introduction of explicit access for all?
IOW: authentication & authorization are present, authorization is simply granted very broadly.
I suspect what we want is the
_user_is_logged_inthing #3508694: Permissions for XB config entity types did forexperience_builder.api.config.list:Because here's the thing: @lauriii wanted XB to both:
JavaScriptComponent::ADMIN_PERMISSIONetc.See:
Comment #5
wim leersEither we must do what I just pushed based on #4, or, and probably that's the safer option,
\Drupal\experience_builder\EntityHandlers\VisibleWhenDisabledXbConfigEntityAccessControlHandlershould be narrows to only logged in users rather than the currentComment #7
wim leersComment #8
wim leersActually, I think we can do both, but perhaps that means the first commit is now obsolete. Did that, now
VisibleWhenDisabledXbConfigEntityAccessControlHandlerTestis (understandably!) failing.Updated cacheability expectations of integration tests; those are passing now. But, this MR still needs to expand
assertAuthenticationAndAuthorization()to facilitate testingGETting an unauthorized individual config entity (i.e. the new test coverage that this issue needs).Leaving that for somebody else to finish 😇
Comment #9
wim leers#3530590: Expand functional test coverage for ContentCreatorVisibleXbConfigEntityAccessControlHandler is in, which means we kinda don't need this test coverage here anymore … except that it would be good to generalize to all XB config entity types, instead of just
Pattern.Comment #10
penyaskitoAdded tests for anonymous GET at
assertAuthenticationAndAuthorizationbased on openapi examples, so we can generalize toallXB config entity types.Comment #11
wim leersVERY nice work here, @penyaskito!
Comment #13
wim leers