Overview

Follow up from #3489106: Show page information in top bar

It'd be beneficial to send the entity keys along with the entity ID and type to the editor, so they can be accessible via configSlice

Proposed resolution

\Drupal\experience_builder\Controller\ExperienceBuilderController::__invoke also pushes the entity type's keys into the settings.

User interface changes

Issue fork experience_builder-3501847

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mglaman created an issue. See original summary.

akhil babu made their first commit to this issue’s fork.

akhil babu opened merge request !582

akhil babu’s picture

akhil babu
he/him
commented

Updated the controller to send the entity type keys

akhil babu’s picture

akhil babu
he/him
commented
Status: Active » Needs review

Please review

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work
akhil babu’s picture

akhil babu
he/him
commented

I have updated to use camel casing. Please review

akhil babu’s picture

akhil babu
he/him
commented
Status: Needs work » Needs review
akhil babu’s picture

akhil babu
he/him
commented
Status: Needs review » Needs work

Conflicts

akhil babu opened merge request !629

akhil babu changed the visibility of the branch 3501847-send-entity-keys to hidden.

akhil babu’s picture

akhil babu
he/him
commented
Status: Needs work » Needs review

Created a new MR. This time I am using snake_case for all parameters as it was more simpler to implement 😬

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Needs work

Discussed with XB's front-end lead, @jessebaker. He'd like us to standardize on camelCase.

Sorry 😅 … but could you adjust the MR accordingly? 😇 I promise a swift review + commit!

akhil babu changed the visibility of the branch 0.x to hidden.

akhil babu’s picture

akhil babu
he/him
commented
Status: Needs work » Needs review

Thanks for the review @wimleers. I have updated the code to camelCase. Changes are made to the drupalsettings.xb values. Please review

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: Unassigned » jessebaker
Status: Needs review » Reviewed & tested by the community
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » Unassigned
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs reroll

This is RTBC, but now conflicts with upstream. :) Almost!

akhil babu’s picture

akhil babu
he/him
commented
Status: Needs work » Needs review

Resolved the conflicts and rebased. Thanks

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs reroll

Thanks!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

wim leers closed merge request !582