Overview

In #3497530: Implement the "Publish All" button @soaratul pointed out that when we return errors from the publish all endpoint, they can't easily be matched to the records in the preview changes pane.

Proposed resolution

Add the entity auto save key to the error objects' meta key so that they can be matched against the items in the preview panel

User interface changes

Issue fork experience_builder-3499791

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

larowlan created an issue. See original summary.

larowlan opened merge request !546

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Assigned: Unassigned » wim leers
Status: Active » Needs review

wim leers made their first commit to this issue’s fork.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +blocker

AFAICT this blocks #3497530: Implement the "Publish All" button.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community

RTBC assuming tests pass with the OpenAPI tightening I've done. Most critical tightening: https://git.drupalcode.org/project/experience_builder/-/merge_requests/5... — without that, the very information @soaratul may or may not exist 😅

Let's guarantee he can rely on it! 😄

  • wim leers committed 0dbe0ca1 on 0.x authored by larowlan 
    Issue #3499791 by larowlan, wim leers: Errors returned from the publish...
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Reviewed & tested by the community » Fixed

🥳

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +openapi
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

Overnight I had some more thoughts on this so opened #3500087: Make AutoSaveManager::getAutoSaveKey static

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.