Overview

Currently, when component is inserted to the canvas, the selection remains on the component that was previously selected. However, when a new component is inserted, the usual next step in the user flow is to edit that component.

Proposed resolution

Mark component as selected after it has been inserted to the canvas.

User interface changes

CommentFileSizeAuthor
#5 Screen Recording 2024-11-06 at 19.18.12.mov3.07 MBel7cosmos

Issue fork experience_builder-3485383

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

lauriii created an issue. See original summary.

matthieuscarset made their first commit to this issue’s fork.

el7cosmos made their first commit to this issue’s fork.

el7cosmos opened merge request !394

el7cosmos’s picture

el7cosmos
Primary language Indonesian
Location 🇮🇩 GMT+7
commented
StatusFileSize
new Screen Recording 2024-11-06 at 19.18.12.mov3.07 MB

I had an attempt at this. Components inserted via the sidebar will then be selected, although the component setting panel will be opened before the component is fully rendered.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

Tested this manually and the behavior seems fine. I agree it would be nice to make the interactions a bit smoother but I wonder if that should be left to a follow-up issue?

Maybe we should add some test coverage for this change?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Status: Active » Needs review

jessebaker made their first commit to this issue’s fork.

hooroomoo made their first commit to this issue’s fork.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs review » Needs work

Could you resolve the merge conflicts after updating HEAD with 0.x since #3486120: Tighten up TS definitions around LayoutNodes/RootNodes etc is in 0.x now?

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

#3484140: Overlay / annotations get misplaced occasionally Seeing this issue sometimes after inserting a new component/section using the Add section/add component button. Don't think it's in scope for this issue but just putting it on people's radar again.

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs work » Needs review
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented

  • hooroomoo committed 3e239772 on 0.x authored by el7cosmos 
    Issue #3485383 by jessebaker, hooroomoo, el7cosmos, lauriii: Select...
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.