Overview


  1. Add a component with 1+ slots
  2. Add a component inside the slot
  3. Delete the parent component
  4. Observe in the layoutModel data that the model for the child component is not deleted.

Proposed resolution

Recursively go through all the child components when deleting a component to ensure that the model for each child is deleted.

User interface changes

CommentFileSizeAuthor
After_delete.png133.36 KBjessebaker
before_delete.png149.02 KBjessebaker

Issue fork experience_builder-3483436

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jessebaker created an issue. See original summary.

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » soaratul

soaratul made their first commit to this issue’s fork.

soaratul opened merge request !376

soaratul’s picture

soaratul commented
Assigned: soaratul » Unassigned
Status: Active » Needs review
jessebaker’s picture

jessebaker commented
Status: Needs review » Needs work

This needs a little more work, see code review on the MR.

soaratul’s picture

soaratul commented
Assigned: Unassigned » soaratul
soaratul’s picture

soaratul commented
Assigned: soaratul » Unassigned
Status: Needs work » Needs review

I think it's now in a good shape to be reviewed.

  • jessebaker committed c2f1a2ee on 0.x authored by soaratul 
    Issue #3483436 by soaratul: When deleting a component with non-empty...
jessebaker’s picture

jessebaker commented
Status: Needs review » Fixed

Great work @soaratul thank you! Marking fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.