It would be really nice if we could make it possible to delete components by pressing the "Delete" button. Currently users need to right click a component and delete it from the contextual menu which can be jarring, especially if you're trying to remove several components at once.
Allow deleting components by pressing "Delete". We need to be careful to not trigger this action when a input field is focused. 😅
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | Delete nodes.mov | 4.17 MB | utkarsh_33 |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
wim leersI thought you were referring to
/admin/structure/component😅 This subtle title tweak clarifies that for me 😇Comment #3
fazilitehreem commentedComment #5
fazilitehreem commentedComment #6
lauriiiThank you @fazilitehreem! It would be great if we could add test coverage for this.
Comment #8
utkarsh_33 commentedSince this is a part of milestone so assigning it to @jessebaker to get reviews.
Comment #9
fazilitehreem commentedComment #10
fazilitehreem commentedComment #11
lauriiiThe MR needs a rebase since a lot of MRs have landed
Comment #12
utkarsh_33 commentedAdding video for reference that we can now delete selected components even if we click outside the iframe as well as if a component is selected via the page hierarchy display.
Comment #13
utkarsh_33 commentedComment #15
wim leersAFAICT tests are present and passing now 👍
@jessebaker has pointed out an oversight over at https://git.drupalcode.org/project/experience_builder/-/merge_requests/2..., so marking .
In there, he also points out a scenario that is currently broken and that the test coverage should be expanded for.
Finally: please include a GIF showing this in action.
Comment #16
wim leersComment #17
utkarsh_33 commentedComment #18
wim leershttps://git.drupalcode.org/project/experience_builder/-/merge_requests/2... is not yet addressed.
Nor is the rest of #15.
Comment #19
fazilitehreem commentedComment #20
fazilitehreem commentedComment #21
wim leersTests aren't passing.
🙏 Please don't mark an issue as needing review until the MR passes tests!
Comment #22
utkarsh_33 commentedComment #24
jessebaker commentedComment #25
lauriiiYay!! Great work everyone! 👏 🎉 Makes deleting components from a page so much easier 🤩
Comment #26
kristen polJust tested with latest changes and it works great, thanks!