Overview

When navigating to /xb/node/1, two requests are sent to 

/api/preview/node/1

:

  • the second one for the actual preview
  • the first one for "the empty canvas/component tree":
    {"layout":{"uuid":"root","nodeType":"root","name":"root","children":[]},"model":{}}

That's wasteful and rather pointless.

Proposed resolution

Eliminate that first request.

User interface changes

TBD

Issue fork experience_builder-3467176

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

Wim Leers created an issue. See original summary.

omkar-pd made their first commit to this issue’s fork.

omkar-pd opened merge request !161

omkar-pd’s picture

omkar-pd commented
Status: Active » Needs review

Utkarsh_33 made their first commit to this issue’s fork.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: Unassigned » jessebaker

Fixed the test.Assigning it to @jessebaker for a review.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: jessebaker » utkarsh_33
Status: Needs review » Needs work
Issue tags: +Needs tests

Does the test actually fail without the non-test change? I don't think it does.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » wim leers
Issue summary: View changes
Issue tags: -Needs tests

Added test for the change.

utkarsh_33’s picture

utkarsh_33 commented
Status: Needs work » Needs review
utkarsh_33’s picture

utkarsh_33 commented
Assigned: wim leers » utkarsh_33
Status: Needs review » Needs work

I'll update the changes.

utkarsh_33’s picture

utkarsh_33 commented
Assigned: utkarsh_33 » jessebaker
Status: Needs work » Needs review

Wim Leers credited jessebaker.

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +Performance, +front-end performance

jessebaker’s picture

jessebaker commented
Assigned: jessebaker » Unassigned
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.