Reported by @jessebaker.
Names like cta1href make no sense:
Use each prop's title, which is present in the schema.
Once #3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria lands, we can make "each prop must have a title" a requirement for SDCs to be eligible for XB. Until then, fall back.
Now you see CTA 1 link 👍
| Comment | File | Size | Author |
|---|---|---|---|
| after.png | 34.06 KB | wim leers | |
| before.png | 32.61 KB | wim leers |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wim leersComment #6
wim leersTest coverage was trivial thanks to @bnjmnm's test coverage he added in #3461422: Evolve component instance edit form to become simpler: generate a Field Widget directly 🚀
Crediting him for making this so delightful 😄
Comment #7
wim leersComment #8
jessebaker commentedVerified that this works as I requested, needs back-end review.
Comment #9
f.mazeikis commentedApproved.
Comment #11
wim leersRe-ran the pipeline, all green as expected. 👍
There's some flakiness with Cypress E2E tests, just like we have with functional JS tests in Drupal core. We've got #3456020-15: Harden Cypress E2E test against environment variability + document Cypress test best practices to fix that.