Follow-up for #3461499: Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings, to fix edge cases identified in #3446722: Introduce an example set of representative SDC components; transition from "component list" to "component tree".
Specifically these edge cases:
- … but that revealed a limitation of the JSON encoding (which is also true of the YAML encoding): all keys are strings. But the keys were meant to be the values. Result:
50as a choice would always be represented by'50': a string, not an integer!- In debugging that, I discovered
::storageSettingsFromConfigData(), which was added ~10 years ago for addressing precisely this problem. Whew! 😅 Fix: https://git.drupalcode.org/project/experience_builder/-/merge_requests/2...
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
utkarsh_33 commentedComment #4
wim leersComment #5
wim leersComment #6
wim leersThis blocks #3446722: Introduce an example set of representative SDC components; transition from "component list" to "component tree" and will block #3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria.
Comment #9
tedbow