Overview

After #3463999: Auto-create/update Component config entities for all discovered SDCs that meet XB's minimum criteria lands, we no longer need the UI for this config entity.

In fact, we no longer want it, because we want the logic that #3461499: Support complex SDC prop shapes: introduce (Storable)PropShape to compute field type storage settings introduced to determine everything.

Proposed resolution

  • ✅ Keep the listing at /admin/structure/component
  • ✅ Remove the add/edit form \Drupal\experience_builder\Form\ComponentEditForm
  • ✅ Update routes accordingly

User interface changes

The listing UI remains, but no longer has the "operations" dropdown, only the "delete" operation:

CommentFileSizeAuthor
#10 Screenshot 2024-08-22 at 2.18.54 PM.png272.65 KBwim leers
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

Wim Leers created an issue. See original summary.

wim leers’s picture

Title: [PP-2] Remove Component config entity's edit form » [PP-2] Remove Component config entity's add/edit form
wim leers’s picture

Title: [PP-2] Remove Component config entity's add/edit form » [PP-1] Remove Component config entity's add/edit form
wim leers’s picture

Title: [PP-1] Remove Component config entity's add/edit form » Remove Component config entity's add/edit form
Status: Postponed » Active

omkar-pd made their first commit to this issue’s fork.

omkar-pd’s picture

Status: Active » Needs review
wim leers’s picture

Issue summary: View changes
Status: Needs review » Needs work

Thanks for pushing this forward! 🙏🥳

AFAICT you thought of all the route things 👍

ComponentEditForm has not yet been updated.

omkar-pd’s picture

Status: Needs work » Needs review

I Missed pushingComponentEditForm. Removed ComponentEditForm and pushed.

wim leers’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new272.65 KB

Tests are passing.

The listing UI still exists, and there's only the Delete operation now 👍

wim leers’s picture

Status: Reviewed & tested by the community » Fixed

  • Wim Leers committed b5851916 on 0.x authored by omkar-pd
    Issue #3464025 by omkar-pd, Wim Leers: Remove Component config entity's...
wim leers’s picture

Component: Page builder » Config management

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.