Problem/Motivation
Within the Menu Example sub module take a look in MenuExampleController.php. and the function tabsPage(). There is a $secondary variable being set (line 154). This involves a ternary function counting the number of slashes. When testing this was always returning the else value ''.
Steps to reproduce
Install and enable Examples module and then enable the Menu Example submodule. Browse to /examples/menu-example/tabs. Click on the bottom "Second" and "Third" tabs (secondary text not showing). Put a breakpoint on MenuExampleController.php line 154, start debugging and in the browser visit /tabs/default/second.
Proposed resolution
Looks like the condition should be > 1 instead of > 2 in the tabsPage() function (MenuExampleController.php line 154).
Remaining tasks
User interface changes
API changes
Data model changes
Issue fork examples-3512242
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
avpadernoComment #3
juandhr commentedWorking on it.
Comment #5
juandhr commentedComment #6
avpadernoComment #8
avpadernoThank you for the issue and the merge request!