Comments

Lal_ created an issue. See original summary.

Lal_’s picture

Title: Remove the core key for the rest example » Remove the core key for the rest example .info.yml
Lal_’s picture

StatusFileSize
new555 bytes
Lal_’s picture

Status: Active » Needs review
Lal_’s picture

Title: Remove the core key for the rest example .info.yml » Give the correct value for core_version_requirement key for the rest example .info.yml
Related issues: +#1883784: New examples for REST API in D8
tyler36’s picture

Status: Needs review » Reviewed & tested by the community

Applies cleanly on Drupal 9.1

    "drupal/core-recommended": "^9.1",
    "drupal/examples": "^3.0",
valthebald’s picture

Status: Reviewed & tested by the community » Needs work

Hello everyone!
The patch assumes that rest example doesn't work with Drupal 8, is that the case?

Pooja Ganjage’s picture

StatusFileSize
new1016 bytes

Hi,

Creating a patch as per the comment in #7.

Please review the patch.

Thanks.

Pooja Ganjage’s picture

Status: Needs work » Needs review
valthebald’s picture

Status: Needs review » Needs work

@Pooja Ganjage same question - what's wrong with the current version requirement? The module should work with both Drupal 8 and 9, so why limit the version only to 9?

tyler36’s picture

@valthebald

The patch is for version 3.x-dev with the explicit support of "Requires Drupal: ^9"

While it may work with Drupal 8, I was working on an assumption of keeping it in line with future support. IE. Use Drupal 9 methods, coding styles best practises etc. I'm new to the community, and was trying to help clear a 9+month old issue.

If this is not the case, then perhaps it tickets should be "closed (works as intended)"?

Pooja Ganjage’s picture

StatusFileSize
new1.01 KB
Pooja Ganjage’s picture

Status: Needs work » Needs review
valthebald’s picture

Status: Needs review » Closed (works as designed)

@tyler36: now I see the confusion! examples.info.yml version requirement is ^9, yet in some submodules it's ^8.7 || ^9
Unless there is example code that works only in Drupal 9, I would leave the version requirement as wide as possible (i.e. ^8.7 || ^9).
I indeed will close the issue as "works as designed"
Thanks everyone!