| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3155779-12.patch | 1.01 KB | Pooja Ganjage |
| #8 | 3155779-8.patch | 1016 bytes | Pooja Ganjage |
| #3 | 3155779-3.patch | 555 bytes | Lal_ |
| Comment | File | Size | Author |
|---|---|---|---|
| #12 | 3155779-12.patch | 1.01 KB | Pooja Ganjage |
| #8 | 3155779-8.patch | 1016 bytes | Pooja Ganjage |
| #3 | 3155779-3.patch | 555 bytes | Lal_ |
Comments
Comment #2
Lal_Comment #3
Lal_Comment #4
Lal_Comment #5
Lal_Comment #6
tyler36 commentedApplies cleanly on Drupal 9.1
Comment #7
valthebaldHello everyone!
The patch assumes that rest example doesn't work with Drupal 8, is that the case?
Comment #8
Pooja Ganjage commentedHi,
Creating a patch as per the comment in #7.
Please review the patch.
Thanks.
Comment #9
Pooja Ganjage commentedComment #10
valthebald@Pooja Ganjage same question - what's wrong with the current version requirement? The module should work with both Drupal 8 and 9, so why limit the version only to 9?
Comment #11
tyler36 commented@valthebald
The patch is for version
3.x-devwith the explicit support of "Requires Drupal: ^9"While it may work with Drupal 8, I was working on an assumption of keeping it in line with future support. IE. Use Drupal 9 methods, coding styles best practises etc. I'm new to the community, and was trying to help clear a 9+month old issue.
If this is not the case, then perhaps it tickets should be "closed (works as intended)"?
Comment #12
Pooja Ganjage commentedComment #13
Pooja Ganjage commentedComment #14
valthebald@tyler36: now I see the confusion! examples.info.yml version requirement is ^9, yet in some submodules it's ^8.7 || ^9
Unless there is example code that works only in Drupal 9, I would leave the version requirement as wide as possible (i.e. ^8.7 || ^9).
I indeed will close the issue as "works as designed"
Thanks everyone!