Fix double occurence of "the" in tabledrag_example_parent_form() and tabledrag_example_simple_form().

CommentFileSizeAuthor
#3 2788163-3.patch1.29 KBShashwat Purav

Issue fork examples-2788163

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shashwat Purav created an issue. See original summary.

Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Iksula commented
Assigned: Unassigned » Shashwat Purav
Status: Active » Needs work
Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Iksula commented
Assigned: Shashwat Purav » Unassigned
Status: Needs work » Needs review
FileSize
2788163-3.patch1.29 KB

Adding patch.

Status: Needs review » Needs work

The last submitted patch, 3: 2788163-3.patch, failed testing.

Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Iksula commented
Assigned: Unassigned » Shashwat Purav
ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
CreditAttribution: ashishdalvi at Iksula commented
Status: Needs work » Needs review

I think test case failure is not related to patch.
Changing status to "Needs review". Feel free to update the status for any issues.

Shashwat Purav’s picture

Shashwat Purav CreditAttribution: Shashwat Purav at Iksula commented
Assigned: Shashwat Purav » Unassigned

Yes Ashish, It seems the test case failure is not related to patch since the patch only removes double occurence of word "the" from comments.

Status: Needs review » Needs work

The last submitted patch, 3: 2788163-3.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

vicheldt’s picture

vicheldt CreditAttribution: vicheldt at CI&T commented
Assigned: Unassigned » vicheldt

vicheldt opened merge request !9

vicheldt’s picture

vicheldt CreditAttribution: vicheldt at CI&T commented
Assigned: vicheldt » Unassigned
Status: Needs work » Needs review
lucienchalom’s picture

lucienchalom CreditAttribution: lucienchalom at CI&T commented
Status: Needs review » Reviewed & tested by the community

The tests failing are not related to this issue, the double word was fixed and no new CS was implemented.
so I'm moving to RTBC
thank you

  • valthebald committed 73832ba on 7.x-1.x authored by vicheldt 
    Issue #2788163: Fix double occurence of "the" in "tabledrag_example".
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Reviewed & tested by the community » Fixed

Merged, thank you all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.