batch_example.module line 91 states:

// Execute the function named batch_example_1 or batch_example_2.

where it should be

// Execute the function named batch_example_batch_1 or batch_example_batch_2.
CommentFileSizeAuthor
#9 wrong_function_names_in-2762919-9.patch772 byteskajalkiran
#6 wrong_func_name_in_comment-2762919-6.patch565 bytesminakshiPh
#2 2762919-2.patch565 bytesmarcoscano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented
Assigned: marcoscano » Unassigned
Status: Active » Needs review
FileSize
2762919-2.patch565 bytes

Status: Needs review » Needs work

The last submitted patch, 2: 2762919-2.patch, failed testing.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
CreditAttribution: marcoscano as a volunteer commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2762919-2.patch, failed testing.

minakshiPh’s picture

minakshiPh CreditAttribution: minakshiPh at Iksula commented
Status: Needs work » Needs review
FileSize
wrong_func_name_in_comment-2762919-6.patch565 bytes

Attaching the patch with valid name convention

Status: Needs review » Needs work

The last submitted patch, 6: wrong_func_name_in_comment-2762919-6.patch, failed testing.

The last submitted patch, 6: wrong_func_name_in_comment-2762919-6.patch, failed testing.

kajalkiran’s picture

kajalkiran CreditAttribution: kajalkiran commented
Assigned: Unassigned » kajalkiran
FileSize
wrong_function_names_in-2762919-9.patch772 bytes

Changing the comment to "Execute the function named batch_example_batch_1() or batch_example_batch_2()."

kajalkiran’s picture

kajalkiran CreditAttribution: kajalkiran commented
Assigned: kajalkiran » Unassigned
Status: Needs work » Needs review
Manav’s picture

Manav CreditAttribution: Manav as a volunteer and at QED42 commented
Status: Needs review » Reviewed & tested by the community

This patch works fine for me.

  • Mile23 committed 11b14f6 on 7.x-1.x authored by minakshiPh 
    Issue #2762919 by marcoscano, kajalkiran, minakshiPh: Wrong function...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Reviewed & tested by the community » Fixed 
+++ b/batch_example/batch_example.module
@@ -88,7 +88,7 @@ function batch_example_simple_form_submit($form, &$form_state) {
+  // Execute the function named batch_example_batch_1() or batch_example_batch_2().

This line needs to wrap at 80 characters. Fixed on commit.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.