Hello,
the block_example.module file contains block_example_block_view_alter function to provide example of the hook operations. In it a string search is performed using stristr.

Using multibyte string operations is currently best practice. The patch attached fixes that.

CommentFileSizeAuthor
#5 use-unicode-strpos-2628916-5.patch998 bytesvaibhavjain
#2 example-multibyte_str_in_block_example-2628916-2.patch988 bytestassos
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tassos created an issue. See original summary.

tassos’s picture

tassos CreditAttribution: tassos at Cameron and Wilding Ltd commented
FileSize
example-multibyte_str_in_block_example-2628916-2.patch988 bytes

Rolling out the patch.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Active » Needs review
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Needs work 
+++ b/block_example/block_example.module
@@ -42,7 +42,7 @@ use Drupal\Core\Block\BlockPluginInterface;
-  if ((!empty($build['#configuration']['label']) && stristr($build['#configuration']['label'], 'uppercase')) || (!empty($definition['subject']) && stristr($definition['subject'], 'uppercase'))) {
+  if ((!empty($build['#configuration']['label']) && mb_stristr($build['#configuration']['label'], 'uppercase')) || (!empty($definition['subject']) && mb_stristr($definition['subject'], 'uppercase'))) {

Nice catch on multibyte, but it looks like we're only ever using this for logic and not to get the string back. Therefore we should use Unicode::strpos().

vaibhavjain’s picture

vaibhavjain
he/him
Primary language Hindi
Location Delhi
CreditAttribution: vaibhavjain at Acquia commented
Status: Needs work » Needs review
FileSize
use-unicode-strpos-2628916-5.patch998 bytes

Attaching updated patch.
No Interdiff attached, as it was not required.

  • Mile23 committed 8ee1a98 on 8.x-1.x authored by tassos 
    Issue #2628916 by tassos, vaibhavjain: Block example does not use...
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Fixed

Thanks!

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented

We'll need to revert this for #2971229: Evaluate Unicode, mb_* usages after 8.6.x deprecations

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.