Problem/Motivation

The Block Module currently has minimal documentation on its block plugin classes and outdated documentation on block_example_block_view_alter().

Proposed resolution

Update and extend the documentation.

Remaining tasks

* Check English spelling and grammar by native speaker.

User interface changes

* Two block titles changed.

CommentFileSizeAuthor
#8 interdiff.txt5.05 KBMile23
#8 2125317_8.patch8.23 KBMile23
#5 block_example-documentation-2125317-5.patch10.06 KBSutharsan
#1 block_example-documentation-2125317-1.patch9.7 KBSutharsan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Issue summary: View changes
Status: Active » Needs review
FileSize
block_example-documentation-2125317-1.patch9.7 KB

Documentation added. Text needs review by a native speaker.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Related: #2125313: Add controller to Example Block

Status: Needs review » Needs work

The last submitted patch, 1: block_example-documentation-2125317-1.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

Looks like it needs a re-roll.

Sutharsan’s picture

Sutharsan CreditAttribution: Sutharsan commented
Status: Needs work » Needs review
FileSize
block_example-documentation-2125317-5.patch10.06 KB

Rerolled.

anavarre queued 5: block_example-documentation-2125317-5.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 5: block_example-documentation-2125317-5.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Category: Task » Bug report
Status: Needs work » Needs review
FileSize
2125317_8.patch8.23 KB
interdiff.txt5.05 KB

Documentation errors are bug reports.

Rerolled (really re-did).

Interdiff reflects some edits.

  • Mile23 committed c11e316 on 8.x-1.x authored by Sutharsan 
    Issue #2125317 by Sutharsan, Mile23: Improve Block Example documentation
Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 as a volunteer commented
Status: Needs review » Fixed

Committed and pushed.

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.