Sub-issue for meta issue #1880976: [meta] Port examples (including submodules) to D9.4+

Problem/Motivation

D8 all the things!

Proposed resolution

Start with D7 version and figure out how to port ;)

CommentFileSizeAuthor
#21 2102625-21.diff6.48 KBvalthebald
#20 2102625-19.diff7.08 KBvalthebald
#16 2102625-15.patch5.5 KBvalthebald
#15 interdiff-2102625-14-15.txt2.34 KBvalthebald
#14 interdiff.txt5.62 KBLal_
#14 2102625-14.patch3.61 KBLal_
#12 action-example-2102625-12.patch3.09 KBjungle
#4 0001-Issue-2102625-Port-action_example-module-to-Drupal-8.patch2.61 KBkandra

Issue fork examples-2102625

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Title: Port email example module to Drupal 8 » Port action example module to Drupal 8
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Title: Port action example module to Drupal 8 » Port action_example module to Drupal 8
kristen pol’s picture

kristen pol
she/her
Primary language English
Location Santa Cruz, CA, USA
commented
Issue summary: View changes

Fix text

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Issue summary: View changes

See changelog: https://drupal.org/node/2020549

kandra’s picture

kandra commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-2102625-Port-action_example-module-to-Drupal-8.patch2.61 KB

Initial version for the basic "do nothing" action :)

marvil07’s picture

marvil07 commented
Status: Needs review » Needs work

Thanks for the start patch, moving to NW since it is unfinished yet.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Related issues: +#2209627: [meta] Module Checklist for Examples

Looks like a good start, but we need a lot more of the documentation and tests from the D7 version.

Converting the tests to D8 can help provide some structure, even if they fail.

Here's the Examples module checklist you can poke through for some guidance: #2209627: [meta] Module Checklist for Examples

Status: Needs work » Needs review

luisfelix1983 queued 4: 0001-Issue-2102625-Port-action_example-module-to-Drupal-8.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 0001-Issue-2102625-Port-action_example-module-to-Drupal-8.patch, failed testing.

martin107’s picture

martin107 commented

Now, I think, I understand all the retesting ....

BlockExampleTest passes locally for me ( php 5.5.10 )

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Yah, it was a branch blocker until yesterday: http://cgit.drupalcode.org/examples/commit/?h=8.x-1.x&id=8e449a79d3da5ed...

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Re-running test.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Status: Needs work » Needs review
StatusFileSize
new action-example-2102625-12.patch3.09 KB

Let's bring it up again, Any further guideline or suggestion would be appreciated.

jungle’s picture

jungle
He/Him
Location Chongqing, China
commented
Version: 8.x-1.x-dev » 3.x-dev
Lal_’s picture

Lal_
He\Him
commented
StatusFileSize
new 2102625-14.patch3.61 KB
new interdiff.txt5.62 KB

Added the schema file and made the changes in the info

valthebald’s picture

valthebald
Location Sofia
commented
StatusFileSize
new interdiff-2102625-14-15.txt2.34 KB

Added the test, and fixed status value in config/install

valthebald’s picture

valthebald
Location Sofia
commented
StatusFileSize
new 2102625-15.patch5.5 KB

Status: Needs review » Needs work

The last submitted patch, 16: 2102625-15.patch, failed testing. View results

valthebald opened merge request !1

valthebald closed merge request !1

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs work » Needs review
StatusFileSize
new 2102625-19.diff7.08 KB
valthebald’s picture

valthebald
Location Sofia
commented
StatusFileSize
new 2102625-21.diff6.48 KB

  • valthebald committed 893ce69 on 3.x 
    Issue #2102625 by valthebald, Lal_, jungle, kandra: Port action_example...
valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.