See #1880976: [meta] Port examples (including submodules) to D9.4+

CommentFileSizeAuthor
#29 1883728-29.patch21.29 KBvalthebald
#27 1883728-27.patch21.27 KBvalthebald
#25 1883728-25.patch21.69 KBvalthebald
#23 1883728-23.patch21.64 KBvalthebald
#21 1883728-21.patch21.54 KBvalthebald
#19 1883728-19.patch22.36 KBvalthebald
#17 1883728-17.patch22.35 KBvalthebald
#15 1883728.patch21.85 KBvalthebald
#2 theming-first-try.patch17.9 KBmarvil07
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
Assigned: Unassigned » marvil07
marvil07’s picture

marvil07 CreditAttribution: marvil07 commented
Assigned: marvil07 » Unassigned
Status: Active » Needs review
FileSize
theming-first-try.patch17.9 KB

Here a first version, but I still have some problems related with render arrays, probably because of #1283892: Let Render API fail in a tale-telling way on invalid $element, so I guess it should be a good idea to try to port render example first.

NR for testbot.

Status: Needs review » Needs work

The last submitted patch, theming-first-try.patch, failed testing.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Needs work » Postponed

@marvil, nice first-go. I'm marking this as postponed but you can go ahead and work on it if you'd like.

Also: It's much better to have documentation inside doxygen docblocks than a README. That way the api.drupal.org can pull it in and make it nice and clicky-linky and relevant. Open up any of the current modules for an example of how this happens. Here's a recent one: http://api.drupal.org/api/examples/field_permission_example%21field_perm...

The Drupal doxygen standards are here: http://drupal.org/node/1354

marvil07’s picture

marvil07 CreditAttribution: marvil07 commented

@Mile23: It would be great to know the reason behind the status change.

About README, I agree, but that's how it is on D7 for this example, so I guess I will try to move it into doxygen, but that's not a blocker for the real porting IMHO.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

You are right... The D7 version has a README, which is the wrong way to go. In fact, it hasn't yet shown up in api.drupal.org.

I'll mark this as needing a backport.

I set it to postponed because you mentioned wanting to wait until the render example is done. You're welcome to change the status if you need to.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented

..wrong tag.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Status: Postponed » Needs work
chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
Assigned: Unassigned » chrisjlee

I'm just going to give this an early shot.

chrisjlee’s picture

chrisjlee CreditAttribution: chrisjlee commented
Assigned: chrisjlee » Unassigned
Issue summary: View changes
Torenware’s picture

Torenware CreditAttribution: Torenware as a volunteer commented
Assigned: Unassigned » Torenware

Might as well learn this for D8. Grabbing it.

Torenware’s picture

Torenware CreditAttribution: Torenware as a volunteer commented

Looks like D7 version is a little busted. The tests don't pass; and the displayed UI is strange in places. Hopefully I can figure out what the intention was.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Assigned: Torenware » Unassigned

Generally unassigning issues. Please re-assign yourself as desired.

Mile23’s picture

Mile23
Primary language English
Location Seattle, WA
CreditAttribution: Mile23 commented
Parent issue: » #1880976: [meta] Port examples (including submodules) to D9.4+
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Version: 8.x-1.x-dev » 3.x-dev
Status: Needs work » Needs review
FileSize
1883728.patch21.85 KB

Status: Needs review » Needs work

The last submitted patch, 15: 1883728.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-17.patch22.35 KB

Status: Needs review » Needs work

The last submitted patch, 17: 1883728-17.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-19.patch22.36 KB

Third time's the charm?

Status: Needs review » Needs work

The last submitted patch, 19: 1883728-19.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-21.patch21.54 KB

Status: Needs review » Needs work

The last submitted patch, 21: 1883728-21.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-23.patch21.64 KB

Status: Needs review » Needs work

The last submitted patch, 23: 1883728-23.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-25.patch21.69 KB

Status: Needs review » Needs work

The last submitted patch, 25: 1883728-25.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-27.patch21.27 KB

Status: Needs review » Needs work

The last submitted patch, 27: 1883728-27.patch, failed testing. View results

valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs work » Needs review
FileSize
1883728-29.patch21.29 KB

  • valthebald committed 66cb9f2 on 3.x 
    Issue #1883728 by valthebald, marvil07: Port theming_example to D8
valthebald’s picture

valthebald
Location Sofia
CreditAttribution: valthebald at Dropsolid commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.