Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Panel panes are natural contenders for serving via Edge Side Includes.
The attached patch is a first-pass at adding panels support to the Esi module.
Comment | File | Size | Author |
---|---|---|---|
#5 | ESI-Fix basic panels support-985198-5.patch | 814 bytes | cmlara |
esi.panels_support.patch | 9.15 KB | manarth |
Comments
Comment #1
Donaldd CreditAttribution: Donaldd commentedThanks manarth for your patch and you slides!
Your slides really helped me get a better understanding of how esi works.
But I have a problem with your patch.
When I patch the module and I add esi as the panel cache. Then panels returns the ESI panes as empty.
What could be the reason of this, am I doing something wrong?
Thanks,
D
Comment #2
Cyberwolf CreditAttribution: Cyberwolf commentedSubscribing.
Comment #3
mikeytown2 CreditAttribution: mikeytown2 commentedThis has been fixed in the 2.x branch. If I am mistaken please re-open.
Comment #5
cmlaraHello,
The initial patch has a few issues. Per DonaldD's comment 1 I was able to duplicate and track down
The biggest issue is “$task_menu_callback” should be “$task_name” on line 669 of esi.module without this the content doesn't render at all when using a panel with areas inside of it. This part is 'critical' against -DEV for the feature to work.
Also versus the original patch for function esi__panel_pane_handler and the active patch I think both have it wrong
Original Patch:
Active in -DEV :
I think this really should be
in order to match the function. This is less critical compared to the first part but I did it in my patch because it seems correct to the code and the esi tags creation.
I think it should be noted there are still other bugs with this patch that I haven't yet debugged but this makes the module work at a basic level
Really good module with this feature in it will help meet my project needs. The panel support is key to my goal of having most the reusable content be services from the frontend Varnish and only feed change data (like comments) from the backend. I just wish 7.x had the feature set of this module
Patch against -DEV attached
Comment #6
mikeytown2 CreditAttribution: mikeytown2 commentedCommitted #5. Re-open issue if you have more code changes; or open a new issue.