Support from Acquia helps fund testing for Drupal Acquia logo

Comments

AndrewsizZ’s picture

Thanks for this issue, we will try to fix this soon.

reswild’s picture

Status: Active » Needs work
FileSize
666 bytes

Here is a patch to be able to install ERPAL Platform on Aegir.

Afterwards I added a custom block with the following PHP code in order to fill out and post the vendor form after installing the site and logging in:

$form = drupal_get_form('erpal_platform_vendor_form');
print render($form);

This could probably be added to the code though, and a friendly message reminding you to configure this after logging in for the first time would be nice too.

Another thing is that ideally, all installation stuff should probably be added to an .install file instead of to .profile.

AndrewsizZ’s picture

Status: Needs work » Needs review

Thanks reswild,
Lats check if it works for someone else!

clemens.tolboom’s picture

Patch makes sense to me. I'm not able to test. I would say commit this.

@reswild not sure I understand

Afterwards I added a custom block with the following PHP code in order to fill out and post the vendor form after installing the site and logging in

Why add a block? Why not add this through hook_requirements ? Or maybe you meant that?

I like the idea to remove this from the .profile as that delays configuration.

reswild’s picture

Yeah, the custom block was just a quick work-around to get my site configured properly.

Adding a warning through hook_requirements sounds like the right approach.

lependu’s picture

Thanks reswild, #2 works for me.

  • AndrewsizZ committed bd1781c on 7.x-3.x authored by reswild
    Issue #2356851 by reswild, clemens.tolboom, AndrewsizZ, lependu: Cannot...
AndrewsizZ’s picture

Status: Needs review » Fixed

Cool, thanks Guys for your help. Commited!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Orkut Murat Yılmaz’s picture

I've just tried to install the dev version and stable version on Aegir, both doesn't work.

The error message is below:

Exception Object ( [message:protected] => Organization: field is required. Full name: field is required. Street: field is required. City: field is required. Postal Code: field is required. Default VAT rate field is required. [string:Exception:private] => [code:protected] => 0 [file:protected] => /var/aegir/platforms/erpal_platform/includes/install.core.inc [line:protected] => 415 [trace:Exception:private] => Array ( [0] => Array ( [file] => /var/aegir/platforms/erpal_platform/includes/install.core.inc [line] => 339 [function] => install_run_task [args] => Array ( [0] => Array ( [display_name] => Vendor information [display] => 1 [type] => form [run] => 3 [function] => erpal_platform_vendor_form ) [1] => Array ( [parameters] => Array ( [profile] => erpal_platform [locale] => en [q] => ) [settings_verified] => 1 [forms] => Array ( [install_settings_form] => Array ( [driver] => mysql [database] => erpalplatformbin [username] => erpalplatformbin [password] => daVjoV9CbS [host] => localhost [port] => 3306 [db_prefix] => ) [install_configure_form] => Array ( [site_name] => erpalplatform.binbiriz.com [site_mail] => orkut@binbiriz.com [account] => Array ( [name] => admin [mail] => orkut@binbiriz.com [pass] => Array ( [pass1] => bExYSb2cbH [pass2] => bExYSb2cbH ) ) [update_status_module] => Array ( [1] => 1 [2] => 1 ) [clean_url] => 1 ) ) [interactive] => [active_task] => erpal_platform_vendor_form [completed_task] => [database_tables_exist] => 1 [installation_finished] => [locales] => Array ( [0] => stdClass Object ( [name] => en [langcode] => en ) ) [parameters_changed] => [profile_info] => Array ( [name] => ERPAL Platform [description] => Install ERPAL Platform [core] => 7.x [php] => 5.3 [distribution_name] => ERPAL Platform [exclusive] => 1 [dependencies] => Array ( [0] => system [1] => user [2] => filter [3] => text [4] => field_sql_storage [5] => field [6] => node [7] => menu [8] => path [9] => dblog [10] => admin_menu [11] => admin_menu_toolbar [12] => search [13] => comment [14] => field_ui [15] => list [16] => file [17] => image [18] => options [19] => number [20] => taxonomy [21] => block [22] => locale [23] => cat [24] => ctools [25] => date [26] => date_api [27] => date_item_ui [28] => date_popup [29] => date_repeat [30] => date_repeat_field [31] => date_views [32] => dfv [33] => entity [34] => entity_token [35] => entityreference [36] => entitycache [37] => commerce_ui [38] => commerce_customer_ui [39] => commerce_order_ui [40] => commerce_product_ui [41] => commerce_line_item_ui [42] => commerce_tax_ui [43] => commerce_price [44] => field_group [45] => field_extrawidgets [46] => libraries [47] => page_manager [48] => panels [49] => panels_everywhere [50] => panels_mini [51] => references_dialog [52] => relation_endpoint [53] => relation [54] => relation_dummy_field [55] => relation_ui [56] => token [57] => views [58] => views_bulk_operations [59] => views_content [60] => pathauto_entity [61] => subpathauto [62] => pathauto [63] => jquery_update [64] => homebox [65] => views_filter_args [66] => module_filter [67] => fpa [68] => ds [69] => viewfield [70] => commerce_custom_product [71] => commerce_line_item_widget [72] => erpal_core_ui [73] => erpal_budget_ui [74] => erpal_output_ui [75] => erpal_commerce_ui [76] => erpal_crm_ui [77] => erpal_invoice_ui [78] => erpal_project_ui [79] => erpal_quote_ui [80] => erpal_payment_modality_ui [81] => erpal_layout [82] => erpal_menu [83] => erpal_platform_core [84] => erpal_reports ) [php_memory_limit] => 128M [version] => 7.x-3.0-beta2+4-dev [project] => erpal_platform [datestamp] => 1445877255 [hidden] => ) [profiles] => Array ( [erpal_platform] => stdClass Object ( [uri] => ./profiles/erpal_platform/erpal_platform.profile [filename] => erpal_platform.profile [name] => erpal_platform ) [testing] => stdClass Object ( [uri] => ./profiles/testing/testing.profile [filename] => testing.profile [name] => testing ) [minimal] => stdClass Object ( [uri] => ./profiles/minimal/minimal.profile [filename] => minimal.profile [name] => minimal ) [standard] => stdClass Object ( [uri] => ./profiles/standard/standard.profile [filename] => standard.profile [name] => standard ) ) [server] => Array ( ) [stop_page_request] => [task_not_complete] => [tasks_performed] => Array ( [0] => install_select_profile [1] => install_select_locale [2] => install_load_profile [3] => install_verify_requirements [4] => install_system_module [5] => install_bootstrap_full [6] => install_profile_modules [7] => install_configure_form ) ) ) ) [1] => Array ( [file] => /var/aegir/platforms/erpal_platform/includes/install.core.inc [line] => 77 [function] => install_run_tasks [args] => Array ( [0] => Array ( [parameters] => Array ( [profile] => erpal_platform [locale] => en [q] => ) [settings_verified] => 1 [forms] => Array ( [install_settings_form] => Array ( [driver] => mysql [database] => erpalplatformbin [username] => erpalplatformbin [password] => daVjoV9CbS [host] => localhost [port] => 3306 [db_prefix] => ) [install_configure_form] => Array ( [site_name] => erpalplatform.binbiriz.com [site_mail] => orkut@binbiriz.com [account] => Array ( [name] => admin [mail] => orkut@binbiriz.com [pass] => Array ( [pass1] => bExYSb2cbH [pass2] => bExYSb2cbH ) ) [update_status_module] => Array ( [1] => 1 [2] => 1 ) [clean_url] => 1 ) ) [interactive] => [active_task] => erpal_platform_vendor_form [completed_task] => [database_tables_exist] => 1 [installation_finished] => [locales] => Array ( [0] => stdClass Object ( [name] => en [langcode] => en ) ) [parameters_changed] => [profile_info] => Array ( [name] => ERPAL Platform [description] => Install ERPAL Platform [core] => 7.x [php] => 5.3 [distribution_name] => ERPAL Platform [exclusive] => 1 [dependencies] => Array ( [0] => system [1] => user [2] => filter [3] => text [4] => field_sql_storage [5] => field [6] => node [7] => menu [8] => path [9] => dblog [10] => admin_menu [11] => admin_menu_toolbar [12] => search [13] => comment [14] => field_ui [15] => list [16] => file [17] => image [18] => options [19] => number [20] => taxonomy [21] => block [22] => locale [23] => cat [24] => ctools [25] => date [26] => date_api [27] => date_item_ui [28] => date_popup [29] => date_repeat [30] => date_repeat_field [31] => date_views [32] => dfv [33] => entity [34] => entity_token [35] => entityreference [36] => entitycache [37] => commerce_ui [38] => commerce_customer_ui [39] => commerce_order_ui [40] => commerce_product_ui [41] => commerce_line_item_ui [42] => commerce_tax_ui [43] => commerce_price [44] => field_group [45] => field_extrawidgets [46] => libraries [47] => page_manager [48] => panels [49] => panels_everywhere [50] => panels_mini [51] => references_dialog [52] => relation_endpoint [53] => relation [54] => relation_dummy_field [55] => relation_ui [56] => token [57] => views [58] => views_bulk_operations [59] => views_content [60] => pathauto_entity [61] => subpathauto [62] => pathauto [63] => jquery_update [64] => homebox [65] => views_filter_args [66] => module_filter [67] => fpa [68] => ds [69] => viewfield [70] => commerce_custom_product [71] => commerce_line_item_widget [72] => erpal_core_ui [73] => erpal_budget_ui [74] => erpal_output_ui [75] => erpal_commerce_ui [76] => erpal_crm_ui [77] => erpal_invoice_ui [78] => erpal_project_ui [79] => erpal_quote_ui [80] => erpal_payment_modality_ui [81] => erpal_layout [82] => erpal_menu [83] => erpal_platform_core [84] => erpal_reports ) [php_memory_limit] => 128M [version] => 7.x-3.0-beta2+4-dev [project] => erpal_platform [datestamp] => 1445877255 [hidden] => ) [profiles] => Array ( [erpal_platform] => stdClass Object ( [uri] => ./profiles/erpal_platform/erpal_platform.profile [filename] => erpal_platform.profile [name] => erpal_platform ) [testing] => stdClass Object ( [uri] => ./profiles/testing/testing.profile [filename] => testing.profile [name] => testing ) [minimal] => stdClass Object ( [uri] => ./profiles/minimal/minimal.profile [filename] => minimal.profile [name] => minimal ) [standard] => stdClass Object ( [uri] => ./profiles/standard/standard.profile [filename] => standard.profile [name] => standard ) ) [server] => Array ( ) [stop_page_request] => [task_not_complete] => [tasks_performed] => Array ( [0] => install_select_profile [1] => install_select_locale [2] => install_load_profile [3] => install_verify_requirements [4] => install_system_module [5] => install_bootstrap_full [6] => install_profile_modules [7] => install_configure_form ) ) ) ) [2] => Array ( [file] => /var/aegir/.drush/provision/platform/drupal/install_7.inc [line] => 150 [function] => install_drupal [args] => Array ( [0] => Array ( [parameters] => Array ( [profile] => erpal_platform [locale] => en ) [settings_verified] => 1 [forms] => Array ( [install_settings_form] => Array ( [driver] => mysql [database] => erpalplatformbin [username] => erpalplatformbin [password] => daVjoV9CbS [host] => localhost [port] => 3306 [db_prefix] => ) [install_configure_form] => Array ( [site_name] => erpalplatform.binbiriz.com [site_mail] => orkut@binbiriz.com [account] => Array ( [name] => admin [mail] => orkut@binbiriz.com [pass] => Array ( [pass1] => bExYSb2cbH [pass2] => bExYSb2cbH ) ) [update_status_module] => Array ( [1] => 1 [2] => 1 ) [clean_url] => 1 ) ) ) ) ) [3] => Array ( [file] => /var/aegir/.drush/provision/platform/drupal/install_7.inc [line] => 169 [function] => install_main [args] => Array ( ) ) [4] => Array ( [file] => /usr/local/src/drush/includes/drush.inc [line] => 74 [args] => Array ( [0] => /var/aegir/.drush/provision/platform/drupal/install_7.inc ) [function] => include_once ) [5] => Array ( [file] => /usr/local/src/drush/includes/engines.inc [line] => 518 [function] => drush_include [args] => Array ( [0] => /var/aegir/.drush/provision/platform/drupal [1] => install ) ) [6] => Array ( [file] => /var/aegir/.drush/provision/platform/provision_drupal.drush.inc [line] => 89 [function] => drush_include_engine [args] => Array ( [0] => drupal [1] => install ) ) [7] => Array ( [function] => drush_provision_drupal_provision_install_backend [args] => Array ( ) ) [8] => Array ( [file] => /usr/local/src/drush/includes/command.inc [line] => 364 [function] => call_user_func_array [args] => Array ( [0] => drush_provision_drupal_provision_install_backend [1] => Array ( ) ) ) [9] => Array ( [file] => /usr/local/src/drush/includes/command.inc [line] => 215 [function] => _drush_invoke_hooks [args] => Array ( [0] => Array ( [description] => Provision a new site using the provided data. [options] => Array ( [client_email] => The email address of the client to use. ) [hidden] => 1 [bootstrap] => 2 [command] => provision-install-backend [command-hook] => provision-install-backend [invoke hooks] => 1 [callback arguments] => Array ( ) [commandfile] => provision [path] => /var/aegir/.drush/provision [engines] => Array ( ) [callback] => drush_command [primary function] => [sections] => Array ( [examples] => Examples [arguments] => Arguments [options] => Options ) [arguments] => Array ( ) [required-arguments] => [sub-options] => Array ( ) [allow-additional-options] => [global-options] => Array ( ) [examples] => Array ( ) [aliases] => Array ( ) [core] => Array ( ) [scope] => site [drush dependencies] => Array ( ) [handle-remote-commands] => [remote-tty] => [strict-option-handling] => [tilde-expansion] => 1 [bootstrap_errors] => Array ( ) [topics] => Array ( ) [category] => provision [argument-description] => Array ( ) [drupal dependencies] => Array ( ) ) [1] => Array ( ) ) ) [10] => Array ( [function] => drush_command [args] => Array ( ) ) [11] => Array ( [file] => /usr/local/src/drush/includes/command.inc [line] => 183 [function] => call_user_func_array [args] => Array ( [0] => drush_command [1] => Array ( ) ) ) [12] => Array ( [file] => /usr/local/src/drush/lib/Drush/Boot/BaseBoot.php [line] => 65 [function] => drush_dispatch [args] => Array ( [0] => Array ( [description] => Provision a new site using the provided data. [options] => Array ( [client_email] => The email address of the client to use. ) [hidden] => 1 [bootstrap] => 2 [command] => provision-install-backend [command-hook] => provision-install-backend [invoke hooks] => 1 [callback arguments] => Array ( ) [commandfile] => provision [path] => /var/aegir/.drush/provision [engines] => Array ( ) [callback] => drush_command [primary function] => [sections] => Array ( [examples] => Examples [arguments] => Arguments [options] => Options ) [arguments] => Array ( ) [required-arguments] => [sub-options] => Array ( ) [allow-additional-options] => [global-options] => Array ( ) [examples] => Array ( ) [aliases] => Array ( ) [core] => Array ( ) [scope] => site [drush dependencies] => Array ( ) [handle-remote-commands] => [remote-tty] => [strict-option-handling] => [tilde-expansion] => 1 [bootstrap_errors] => Array ( ) [topics] => Array ( ) [category] => provision [argument-description] => Array ( ) [drupal dependencies] => Array ( ) ) ) ) [13] => Array ( [file] => /usr/local/src/drush/includes/preflight.inc [line] => 64 [function] => bootstrap_and_dispatch [class] => Drush\Boot\BaseBoot [type] => -> [args] => Array ( ) ) [14] => Array ( [file] => /usr/local/src/drush/drush.php [line] => 12 [function] => drush_main [args] => Array ( ) ) ) [previous:Exception:private] => )

bechtold’s picture

Hey,
I don't know much about aegir atm.
But this bug sounds like the vendor information that is entered during installation is missing.
Can you try to add the information in the installation process?
I don't know how aegir works exactly but I know that all the information can also also be entered as parameters when installing via drush.

It would actually be better to open a new issue if your problem persists since this one was closed about a year ago and I'm not sure if this is the same problem as the initial issue.

Cheers
bechtold

caldenjacobs’s picture

Status: Closed (fixed) » Needs review

Hullo Bechtold! It turns out @Orkut Murat Yılmaz was correct to mention his issue here. The patch in #2 which had been committed has somehow been removed since. When reapplied to the beta2 or dev release, everything works fine once again.

Could we have that recommitted?

Essentially all it does is tell Erpal not to require data entry if CLI is utilized, which is required by Aegir/Drush.

Cheers

Orkut Murat Yılmaz’s picture

Sorry @bechtold, I forgot replying your comment. @caldenjacobs wrote instead of me.

I applied the patch and it starts working.

So that, patch needs to be recommited.

bechtold’s picture

Hey,
thanks for clarifying this.

I looked into this again and I found out why we removed it.
The reason is that we use drush to install ERPAL, actually automated by a phing task.
If we remove this now we can't properly install ERPAL with drush anymore.
The information entered in that installation step is necessary for ERPAL to correctly work and when installing with drush I would expect it to work correctly.
So in my opinion we should not remove this. But I will discuss this with the rest of the team.

All the information needed in that step can be added to drush as parameters and it works fine like so:

drush --db-url="mysql://admin:admin@localhost/local_erpal-platform-dev" --site-name="ERPAL Platform - January 14 2016" --site-mail=""bechtold@brightsolutions.de"" --account-mail=""bechtold@brightsolutions.de"" --locale="en" --nocolor --root="/Users/oskar/workspace/brightsolutions/erpal-platform-dev" --yes site-install "erpal_platform" "install_configure_form.update_status_module='array\(FALSE,FALSE\)'" "erpal_platform_vendor_form.vendor.organization=Bright Solutions GmbH" "erpal_platform_vendor_form.vendor.vendor_phone.phone=+49 0 6151 / 39 10 79 3" "erpal_platform_vendor_form.vendor.vendor_email.email=info@brightsolutions.de" "erpal_platform_vendor_form.vendor.vendor_address.fullname=Brightsolutions GmbH" "erpal_platform_vendor_form.vendor.vendor_address.country=DE" "erpal_platform_vendor_form.vendor.vendor_address.street=Pallaswiesenstraße 63" "erpal_platform_vendor_form.vendor.vendor_address.city=Darmstadt" "erpal_platform_vendor_form.vendor.vendor_address.postal_code=64293" "erpal_platform_vendor_form.vendor.currency=EUR" "erpal_platform_vendor_form.vendor.vat_rate=".19""

I didn't find out if aegir is using drush, so I can't say if this should work.
Could you check this?

I'm wondering how other distributions are handling this or how aegir is handling other distributions.
Commerce Kickstart for example also has multiple steps added to the installation process. Is it possible to install this via aegir?

Do you have any other suggestions how we could fix this?

Until we have further insights on this I suggest using the patch when using aegir and not breaking ERPALs install process.

reswild’s picture

Aegir installs sites using the Provision module (www.drupal.org/project/provision). This does use Drush, but I suspect it would be quite a bit of work to configure this to use the install process you suggest. It's not something I would bother with, as it's a lot easier to just hack your installation profile to work with Aegir.

I think it would also be more user friendly if you just send people to a form to fill in these details after they log into the site for the first time. You could also set these fields to be filled in with dummy values if values are not provided during install, and then ask users to update these afterwards. In either case, the reminder to do this could be added through hook_requirements as suggested earlier.

bechtold’s picture

Status: Needs review » Postponed

I'm not sure if it would be more user friendly to send the user to a form after install. It would't make a difference as it would be the same form as you fill in during the installation.
But I guess just sending the user to the vendor form would ease the programmatic effort of building a form and saving the data during installation.

It would need some resources to implement this though and we need them more on other features and bugs at the moment.
So I will keep this in mind and we might change it later and do it different for d8.
And as you said, adding those two lines is not so hard.

Maybe someone wants to contribute a patch to do that. You are more than welcome to do that.

So for now we keep it as is and Aegir users just patch or comment out or add the if.
I hope that is ok for you.