Problem/Motivation

Right now there are several implementations of the drupalSettings array, this is totally unnecessary.

Steps to reproduce

See favicon implementation in:
- Page top
- Toolbar

Proposed resolution

Just add the conditions for favicon inclusion to environment_indicator_preprocess_html

Remaining tasks

User interface changes

API changes

Integration developers no longer need to add drupalSettings handling because drupalSettings is now independent of indicators like toolbar.

Data model changes

Issue fork environment_indicator-3530674

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

trackleft2 created an issue. See original summary.

trackleft2 opened merge request !113

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Title: Favicon indicator should be handled in one place. » Centralize favicon handling in environment_indicator module.
Issue summary: View changes
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Active » Needs review
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Title: Centralize favicon handling in environment_indicator module. » Centralize drupalSettings handling in environment_indicator module.
Issue summary: View changes

  • trackleft2 committed 2631205d on 4.x 
    Issue #3530674: Centralize drupalSettings handling in...
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.