Problem/Motivation

After upgrading from 4.08 to 4.0.14, "Configure" link is displayed even if user does not have the appropriate permission.

Steps to reproduce

  • Install environment_indicator 4.0.14.
  • Give authenticated role the 'access environment indicator' but not the 'administer environment indicator settings' permissions.
  • Give authenticated role the permission to use the toolbar.
  • Login as authenticated user
  • Click the environment indicator in the toolbar an you should see the "Configure" link.
  • Click "Configure link" and get "Access Denied".

Proposed resolution

Do not render "Configure" link in the toolbar if the role does not have "administer environment indicator settings" permissions.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork environment_indicator-3342457

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gwvoigt created an issue. See original summary.

Peacog made their first commit to this issue’s fork.

Peacog opened merge request !23

peacog’s picture

peacog commented
Status: Active » Needs review

Created a MR that solves this.

devkinetic’s picture

devkinetic commented
Status: Needs review » Reviewed & tested by the community

This looks good!

isholgueras made their first commit to this issue’s fork.

  • isholgueras committed 104d59e5 on 4.x authored by Peacog 
    Issue #3342457 by Peacog, gwvoigt, devkinetic: Configure link is...
isholgueras’s picture

isholgueras commented
Status: Reviewed & tested by the community » Fixed

Thanks for the patch

isholgueras’s picture

isholgueras commented
Status: Fixed » Closed (fixed)