Problem/Motivation

This module modifies the position of Gin toolbar panels by use of the variable --ginToolbarWidthCollapsed. That variable is no longer available in Gin RC1, only if legacy mode were turned on.

This variable should be replaced by --gin-toolbar-width-collapsed.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

jurgenhaas created an issue. See original summary.

jurgenhaas’s picture

Status: Active » Needs review
seutje’s picture

Status: Needs review » Reviewed & tested by the community

I stumbled on the same issue and 10 minutes ago, I checked if there was already an issue for it. There wasn't, so I checked out the project to make a patch. I come back to create the issue and lo-and-behold, Jurgen beat me to it!
My solution was exactly the same, so I can confirm this works and marking it RTBC.

jurgenhaas’s picture

Nice :-)

seutje’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new746 bytes

Note that this does mean that if you want to use this with gin_toolbar, it does require gin to be at least 3.0-rc1.
If we were to use a fallback, it would work with any version.
Not sure how I extend your fork, so I'm just going to add a patch file that uses the fallback method.

tijsdeboeck’s picture

StatusFileSize
new16.97 KB
new11.22 KB

I've tested MR !14, it applies cleanly and solves the overlapping issue 👍

I've attached a screenshot without, and with the patch applied.

tijsdeboeck’s picture

Status: Needs review » Reviewed & tested by the community
norman.lol’s picture

RTBC++

hydra’s picture

RTBC++

godotislate’s picture

RTBC++

justcaldwell made their first commit to this issue’s fork.

justcaldwell’s picture

Status: Reviewed & tested by the community » Needs review

The changes so far are excellent, but they don't account for whether the toolbar is open (--gin-toolbar-width) or collapsed (--gin-toolbar-width-collapsed). I updated the fork to do that.

norman.lol’s picture

And then the indicator was too big?

justcaldwell’s picture

Issue summary: View changes
StatusFileSize
new106.08 KB

Hi @leymannx! Apologies in advance, as I'm not sure I fully understand your question. My update doesn't change the size of the indicator, I'm updating the position of the "flyout" menu/panel to account for whether the vertical gin toolbar is expanded or collapsed. I hope this image helps to clarify (click for full size):

Demo of the latest CSS changes.

The previous changes worked well for a collapsed toolbar. But, for example, if I'm using the expanded toolbar, and I'm attempting to click the 'Structure' item title text (not the icon), the menu immediately appears and I'm suddenly clicking the 'Block Layout' item.

This behavior is consistent with the Gin toolbar when Environment Indicator is not enabled. I hope this helps.

justcaldwell’s picture

StatusFileSize
new71.47 KB
new65.44 KB

Sorry to further muddy the water, but I just realized that all of the changes so far break the submenus when Gin toolbar is in "mobile" mode. Before my updates in #12/13, the sub-menus look like the screenshot below:

Broken submenus

After my changes, the submenu items aren't visible at all:

Broken submenus after #12

It looks like all of this should be wrapped in a media query, but I wanted to see if anyone else can confirm this issue before I make any additional changes.

The media query that seems to be appropriate based on Gin's CSS is:

@media (min-width: 61em) { 
  /* previous changes here */
}

At least that works in my initial testing.

jurgenhaas’s picture

@justcaldwell sorry, I'm not seeing that problem. And I'm uncertain if and how this is related to the environment_indicator. Without your extra changes, the indicator, the horizontal Gin extra toolbar and the vertical Gin toolbar (expanded and collapsed) just work fine AFAICT. Is the extra change possibly unrelated and, if still an issue, worth a separate issue?

justcaldwell’s picture

StatusFileSize
new263.97 KB
new261.44 KB
new40.35 KB

This comment will be the basis of a separate issue.

justcaldwell’s picture

So I've just now realized that this issue is really just about updating a CSS variable that changed in Gin RC1. My apologies! I'll revert my changes and open separate issues.

justcaldwell’s picture

Status: Needs review » Reviewed & tested by the community
e0ipso’s picture

Thanks for all the work here!

e0ipso’s picture

  • e0ipso committed 51ebebb4 on 4.x authored by jurgenhaas
    Issue #3324520 by justcaldwell, jurgenhaas, seutje, tijsdeboeck,...
e0ipso’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.