getTitle() in Toolbar Handler returns null value, crashes site

Above patch is not applying so created other one. Kindly review it. Issue is occurring when module is installed. Check any page it will throw error so after applying attached patch it's working fine.

Attaching updated patch; #4 didn't work for me, line number was wrong.

Updated patch file (without the .txt extension)

Patch file at #4 is correct - the patches at #6 and #7 have full paths which result in a file not found error when composer tries to apply the patch.

In case it helps, you need the following in your composer.json:

{
    "extra": {
        "patches": {
            "drupal/environment_indicator": {
                "getTitle() in Toolbar Handler returns null value, crashes site - Drupal.org issue #3324429 patch from comment #4": "patches/issue-3324429.patch"
            }
        }
    }    
}

You'll also need to save patch #4 into a patches/ directory located alongside your composer.json.

Run composer install to patch the file:

> Drupal\Core\Composer\Composer::vendorTestCodeCleanup
  - Applying patches for drupal/environment_indicator
    patches/DD-1421-environment_indicator-toolbar_handler_returns_null-3324429-4.patch.txt (getTitle() in Toolbar Handler returns null value, crashes site - Drupal.org issue #3324429 patch from comment #4)

/Alex

Patch #4 worked for me. Latest patch as mentioned had error.

> Oh! Sorry for not truncating those filepaths. Thanks for the reminder!

No woz - apologies if my message sounded grumpy; it wasn't intended to be :-)

/Al

Patch in #4 resolved fatal errors/test failures for us. Good mitigation of the issue for now.

While #4 fix the fatal error I don't think it is the proper fix. The environment name may not exist so getTitle() does not always return a string. Also it breaks the UI like this:

Here is a different approach.

When no environment name is set:

When the environment name is set:

Sorry wrong patch.

+++ b/src/ToolbarHandler.php
@@ -218,9 +219,9 @@ class ToolbarHandler implements ContainerInjectionInterface {
     return ($release) ? '(' . $release . ') ' . $environment : $environment;

Side note but should this use $this->t instead ? I mean should it not return translatable markup ?

I'd the same issue and the patch on https://www.drupal.org/project/environment_indicator/issues/3324429#comm... works as expected.

I've follow the same approach and to fix the issue before find the patch

thanks

I can verify that Patch 4 works.

I'm in the same boat as #14: I tested on a local environment that doesn't have an environment name set, and patch #4 results in a misalignment in the UI (see first attached screenshot; the red box is just from me redacting the username). I then tested patch #16 and confirmed that that is working (see second screenshot).

I'll wait to mark as RTBC until someone who does have an environment name tests #16, but that one looks good to me.

Thanks!

I can confirm that Patch 16 works with Drupal 9.5.0 on DDEV environment.
Here's what my patches object looks like in composer.json

"patches": {
            "drupal/environment_indicator": {
                "getTitle() in Toolbar Handler returns null value, crashes site - Drupal.org issue #3324429 patch from comment #16": "https://www.drupal.org/files/issues/2022-12-08/3324429-16.patch"
            }
        }

And then composer update

Thanks for the contribution everyone!

This was released in 4.0.12.