Problem/Motivation

In #3156863: Gin Toolbar support and #3247637: Improvements when using Gin theme support was add for the Gin admin theme and the related toolbar. Gin also works well with the Admin Toolbar module, however when Environment Indicator is enabled the flyout menus are very hard to open due to an unwanted margin:

Steps to reproduce

Enable:

  • Gin
  • Gin Toolbar
  • Admin Toolbar
  • Environment Indicator

Proposed resolution

Override the Gin vertical toolbar styles to take the new margin into account.

Remaining tasks

  • Validate the proposed solution
  • Write code
  • Reviews

User interface changes

API changes

None

Data model changes

None

CommentFileSizeAuthor
#6 Gin___Drupal_-_Composer.png92.02 KBplach
#3 Fullscreen_14_09_2022__12_39.png122.85 KBplach
Fullscreen_14_09_2022__12_39.png122.85 KBplach
Fullscreen_14_09_2022__12_34.png152.97 KBplach

Issue fork environment_indicator-3309626

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

plach created an issue. See original summary.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue summary: View changes
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Issue summary: View changes
StatusFileSize
new Fullscreen_14_09_2022__12_39.png122.85 KB

plach opened merge request !10

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
Assigned: plach » Unassigned
Status: Active » Needs review

This implements the suggested fix.

plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented
StatusFileSize
new Gin___Drupal_-_Composer.png92.02 KB

Does it make sense to use margin-inline-start? However, if this is mimicking Gin's implementation, I would rather keep it like this.

Hey, thanks for the fast review!

Yes, I just copied the original Gin code and tweaked it to take the additional 3px into account.

I just pushed a commit to restore the proposal at #3156863-6: Gin Toolbar support, since it seems it regressed in the meantime:

(plus a cleanup commit, sorry for the scope-creep ;)

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Status: Needs review » Fixed

I don't use Gin, so I cannot test locally. I trust the screenshots and the work here.

Merging. Drupal.org is not working right now. I will retry later.

  • e0ipso committed c8eca01 on 4.x authored by plach 
    Issue #3309626 by plach: Integration with Gin Toolbar and Admin Toolbar
plach’s picture

plach
he/him
Primary language Italian
Location Venezia
commented

Awesome, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.