I am currently trying the Gin admin theme with the Gin Toolbar and it looks absolutely fantastic.
However Environment indicator and Gin Toolbar do not work together at the moment.
What would be needed to make Environment Indicator support The Gin Toolbar?
Or should I make this feature request at the Gin Toolbar module?
| Comment | File | Size | Author |
|---|---|---|---|
| #13 | gin-toolbar-support-3156863.patch | 2.96 KB | fredysan |
| #13 | toolbar.png | 8.08 KB | fredysan |
| #11 | Screen Shot 2021-07-07 at 12.53.40 PM.png | 37.15 KB | nbozoglu |
| #11 | Screen Shot 2021-07-07 at 12.50.59 PM.png | 46.49 KB | nbozoglu |
| #6 | 3156863_vertical.png | 25.51 KB | inaw |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
adamjuran commentedFollowing
Comment #3
johan den hollander commentedComment #6
inaw commentedI have made an attempt to implement the ideas from #3158020 directly in the environment_indicator module.
Gin toolbar with horizontal toolbar:
Gin toolbar with vertical toolbar:
I have created a MR, the patch can be tested like this: https://git.drupalcode.org/project/environment_indicator/-/merge_request...
I'm not sure if the changes are in the right place in this module or if certain parts should be better mapped in gin_toolbar.
Happy to get some feedback.
Comment #8
e0ipsoAwesome idea! This is merged.
Comment #10
keboca commented@e0ipso + @InaW Is there a way we can include the following line as well? (I tried to do it by a MR but somehow I am not able to do so, -- contribute with modules is starting to be more difficult, IMO)
$('head', context).append("<style>.toolbar .toolbar-bar #toolbar-item-administration-tray a.toolbar-icon-admin-toolbar-tools-help.toolbar-icon-default::before{ background-color: " + settings.environmentIndicator.bgColor + " }</style>");I would like to allow modify the site icon background, and I was able to do so by adding the line above. The thin line + the background icon give a better sense of which environment you're working on.
Comment #11
nbozoglu commentedI'm having an issue where my icon next to my environment ID is not showing. Here is a screenshot:
And it should show like this (next to 'VM'):
is there something I'm missing? Thanks in advance.
Comment #12
batigolix@athenerus. This seems to be have been fixed in 4.0.3
Comment #13
fredysan commentedI recently installed the module but the toolbar was not reflecting the configured colors for the environment. So after inspecting the code I noticed that the toolbar HTML ids were not the right ones.
Drupal version: 9.2.9
Environment Indicator Module version: 4.0.3
Toolbar type: Horizontal, Modern toolbar (Also tested on the Sidebar and Legacy toolbars)
Comment #14
batigolix@fredysan: I like your solution better than the one that was committed to 4.0.3
But this issue is closed. Can you create a new issue for this?
Comment #15
dpacassiWe currently have one open Gin issue in this module, I would propose to move discussion there:
#3247637: Improvements when using Gin theme
I personally prefer the patch there as painting the whole menu with a custom color seems very invasive UI/UX wise and kinda destroys the nice UX users get from the Gin admin theme.