Review of the 8.x-3.x branch :
There some issues with code standards.
Should be fixed.
FILE: environment_indicator/environment_indicator.module
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
25 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
30 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
39 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
40 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
41 | WARNING | Do not concatenate strings to translatable strings, they should be part of the t() argument and you should use placeholders
43 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
--------------------------------------------------------------------------------------------------------------------------------------------
FILE: environment_indicator/src/EnvironmentIndicatorPermissions.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
24 | WARNING | Unused variable $machine.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | codingstandard-3154202-3.patch | 5.49 KB | shetpooja04 |
Comments
Comment #2
shetpooja04 commentedComment #3
shetpooja04 commentedI have fixed the coding standards as mentioned in the description
Comment #4
pratik_kambleComment #5
deepalij commentedComment #6
deepalij commentedVerified and tested patch #3. Patch applied successfully and looks good to me.
Testing Steps:
1. Check for the warnings by running the 'phpcs' command --> $ phpcs ./ --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml
2. Check the Warnings/Error found
3. Apply the patch
4. Again run the 'phpcs' command --> phpcs ./ --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,yml
5. Check the warnings/errors if found
Testing Result:
Warnings/errors were not fond after applying the patch and it is as per the coding standards.
Can be move to RTBC.
Comment #7
e0ipsoThanks for the contribution!
Comment #9
e0ipso