Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Adding a composer.json file will allow this module to be searchable (and managable) using composer.
Comment | File | Size | Author |
---|---|---|---|
#12 | interdiff.txt | 9.11 KB | Lal_ |
#12 | 2653102-12.patch | 5.12 KB | Lal_ |
#9 | 2653102-9.patch | 4.11 KB | Suresh Prabhu Parkala |
#4 | composer_json-2653102-2.patch | 4.1 KB | Eyal Shalev |
Comments
Comment #2
Eyal ShalevComment #3
e0ipsoPatch is empty :-)
Comment #4
Eyal ShalevI've re-uploaded the patch.
Comment #5
Eyal ShalevComment #6
Dane Powell CreditAttribution: Dane Powell at Acquia commentedComment #7
ericduran CreditAttribution: ericduran at NBCUniversal commented^^ That statement is not true. I'm using this module now via composer. If we add this composer.json it'll break things.
The drupal dependency should also be removed from that file.
This line should be removed
This line should also be removed.
Comment #8
naveenvalechacomposer.json is not mandatory https://www.drupal.org/docs/creating-custom-modules/add-a-composerjson-f...
Quoting from the above documentation page.
Comment #9
Suresh Prabhu Parkala CreditAttribution: Suresh Prabhu Parkala at Specbee commentedRemoved "drupal/core" and "minimum-stability" statements and added description in the composer file. Please review the patch.
Comment #10
Lal_I think we need to add the dependencies here, the module is depended to color module
Comment #11
Lal_my bad color module is in core.
Comment #12
Lal_Adding more details on the patch...
Comment #13
naveenvalechaper #8 closing this.
Comment #14
tyler36 CreditAttribution: tyler36 at Inter Quest commentedWhile a `composer.json` is _not_ required for Drupal 9 compatibility, I think it's better to include it.
- Drupal 8+ has moved towards "composer" to manage dependencies and modules.
- It allows easier "path" respository symlink via composer for local development.
- It appears to be "unoffical best practise"; most popular modules include a "composer.json" file.