Environment Indicator can break Responsive Preview when used with Navbar, because it overrides the text color everywhere in the Navbar including the links to preview on a device. The Responsive Preview button div has a white background, and Environment Indicator usually forces white text, making it unreadable.

CommentFileSizeAuthor
#5 environment_indicator_incompatibility_with_responsive_preview-2541742-5.patch836 bytesilkkave
#4 environment_indicator-incompatibility_with_responsive_preview-2541742-4.patch837 bytesilkkave
#3 configure_link_not_visible.jpg290.81 KBilkkave
#1 environment_indicator-2541742-1.patch1.13 KBDane Powell
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dane Powell’s picture

Dane Powell CreditAttribution: Dane Powell at Acquia commented
Status: Active » Needs review
FileSize
environment_indicator-2541742-1.patch1.13 KB

There are a lot of ways to fix it, this is just one- making the navbar color replacing selector a little less zealous.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs review » Needs work

Under those circumstances you can set the EI text color to a different color. Also, any specific color combination can be dealt with in custom code.

ilkkave’s picture

ilkkave CreditAttribution: ilkkave commented
FileSize
configure_link_not_visible.jpg290.81 KB

The patch would still show the "Configure devices" link of Responsive Preview with a white text, making it not visible:

Configure link not visible

ilkkave’s picture

ilkkave CreditAttribution: ilkkave commented
FileSize
environment_indicator-incompatibility_with_responsive_preview-2541742-4.patch837 bytes

If we want to target only navbar links, we could target those with class ".navbar-icon" http://cgit.drupalcode.org/navbar/tree/navbar.module?h=7.x-1.7#n548.

Attached a patch with that change.

ilkkave’s picture

ilkkave CreditAttribution: ilkkave commented
FileSize
environment_indicator_incompatibility_with_responsive_preview-2541742-5.patch836 bytes

Got a nasty typo to the first patch, here's a fixed one.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs work » Closed (won't fix)

Version for D7 is unmaintained. I am sorry for the inconvenience.