Loving the new 2.x branch of environment indicator, and now that you can programatically provide the colors in the settings file, this is a winner over the 1.x branch.

We do however need to change the toolbar drawer color, as by default JavaScript programatically makes this 25% lighter then the main color used for the toolbar. This leads to really ugly color combinations, and essentially limits your choice of color palette.

Attached is a patch that optionally adds a new variable, that if not provided will default to the old behavior (so no need to provide any upgrade path).

Also patched the README file to explain this.

Example settings.php file with the new variable:

// Configure environment module.
$conf['environment_indicator_overwrite'] = TRUE;
$conf['environment_indicator_overwritten_name'] = 'DEVELOPMENT';
$conf['environment_indicator_overwritten_color'] = '#9bb03b';
$conf['environment_indicator_overwritten_drawer_color'] = '#333333';
$conf['environment_indicator_overwritten_text_color'] = '#ffffff';
$conf['environment_indicator_overwritten_position'] = 'top';
$conf['environment_indicator_overwritten_fixed'] = FALSE;
CommentFileSizeAuthor
#8 2343823-environment_indicator-drawer-color-8.patch9.22 KBjweowu
#5 2343823-environment_indicator-drawer-color-5.patch9.88 KBwiifm
#2 2343823-environment_indicator-drawer-color-2.patch5.5 KBwiifm
#1 2343823-environment_indicator-drawer-color-1.patch5.76 KBwiifm
environment_indicator-drawer-color.patch6.07 KBwiifm
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm commented
FileSize
2343823-environment_indicator-drawer-color-1.patch5.76 KB

Whoops, patch against the git root, try this.

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm commented
FileSize
2343823-environment_indicator-drawer-color-2.patch5.5 KB

OK, one more shot.

Gold’s picture

Gold
they/them
Location 20 minutes in the future
CreditAttribution: Gold commented
Status: Needs review » Reviewed & tested by the community

This looks much better. I have this patch running and it doesn't appear to introduce any extra issues.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Reviewed & tested by the community » Needs work

Thanks a lot for the patch! It looks great, but it's missing some features.

This should be accompanied by the possibility to choose the drawer color also using the UI environment indicators.

wiifm’s picture

wiifm
Primary language English
Location Wellington, NZ
CreditAttribution: wiifm commented
Status: Needs work » Needs review
FileSize
2343823-environment_indicator-drawer-color-5.patch9.88 KB

Alright, I have added the ability to control the drawer color through the UI, also this is now saved with the ctools exportables. Also added in farbtastic support for the color picker.

Example export:

$environment = new stdClass();
$environment->disabled = FALSE; /* Edit this to true to make a default environment disabled initially */
$environment->api_version = 1;
$environment->machine = 'default_environment';
$environment->name = 'Default environment';
$environment->regexurl = '.*';
$environment->settings = array(
  'color' => '#fcff33',
  'drawer_color' => '#f00000',
  'text_color' => '#1d0101',
  'weight' => '99',
  'position' => 'bottom',
  'fixed' => 0,
);
Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar commented
Status: Needs review » Reviewed & tested by the community

The colour picker in the UI for the drawer works as specified without any obvious bugs. Great patch, thanks wiifm.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso commented
Status: Reviewed & tested by the community » Needs work

In my opinion this adds a great deal of control to the appearance of the indicator, but it adds more complexity to the indicator configuration.

Would you be up to add the farbtastic picker in a collapsed fieldset (maybe labelled More options) and make it optional? If nothing is selected there, then the current behavior is applied.

Thanks for this great patch!

jweowu’s picture

jweowu CreditAttribution: jweowu commented
FileSize
2343823-environment_indicator-drawer-color-8.patch9.22 KB

Re-rolled #5 against HEAD. No other changes.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Needs work » Closed (won't fix)

Version for D7 is unmaintained. I am sorry for the inconvenience.