Taxonomy terms are not translated in Views exposed filter when using entity reference. [#1865756]

When adding an entity reference field as a filter (one that refers to a taxonomy term), the terms are not translated. Render views filter as select list is enabled in the field settings.

This patch replaces $term->name with a call to entity_label.

Comment	File	Size	Author
#8	1865756-8.patch	935 bytes	rpayanm
#8	7.x-1.x: PHP 5.6 & MySQL 5.5, D7 10 pass PHP 5.6 & PostgreSQL 9.1, D7 run-tests.sh exception
#5	entityreference-localize-taxonomyterm-name-1865756-5.patch	910 bytes	peterpoe
#5
	entityreference-localize-taxonomyterm-name-D7.patch	1.05 KB	Stevel

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Stevel CreditAttribution: Stevel commented 13 December 2012 at 14:50

For information: I looked at #1857608: Translation doesn't affect exposed term filters due to bypassing entity system for the idea of this fix.

Comment #2

e0ipso

Catalan

Can Picafort

CreditAttribution: e0ipso commented 18 April 2013 at 18:11

entityreference-localize-taxonomyterm-name-D7.patch queued for re-testing.

Comment #3

milos.kroulik CreditAttribution: milos.kroulik commented 2 October 2014 at 08:52

Issue summary:

View changes

The patch no longer apply. I will try to patch manually.

error: patch failed: plugins/selection/EntityReference_SelectionHandler_Generic.class.php:542
error: plugins/selection/EntityReference_SelectionHandler_Generic.class.php: patch does not apply

EDIT: Code is now completely different, will need another patch.

Comment #4

milos.kroulik CreditAttribution: milos.kroulik commented 2 October 2014 at 08:55

Status:

Needs review

» Active

Comment #5

peterpoe CreditAttribution: peterpoe commented 20 November 2014 at 15:42

Status:

Active

» Needs review

File	Size
entityreference-localize-taxonomyterm-name-1865756-5.patch	910 bytes

New patch, using handler method getLabel() instead of calling directly entity_label().

Comment #6

chaloalvarezj CreditAttribution: chaloalvarezj commented 13 October 2017 at 15:19

Hi there,
I have this problem in the latest stable version on entity reference (7.x-1.5), but the patch in #5 doesn't seem to apply as the code has changed.
Has anybody else found this problem recently? How to Fix it?
Thank you.

Edit: Never mind! It is working! I did not have my terms translated.. Sorry.

Comment #7

Chris Matthews CreditAttribution: Chris Matthews as a volunteer commented 30 January 2019 at 01:25

Status:	Needs review	» Needs work
Issue tags:		+Needs reroll

The 4 year old patch in #5 to EntityReference_SelectionHandler_Generic.class.php does not apply to the latest 7.x-1.x-dev and if still relevant needs a reroll.

Checking patch plugins/selection/EntityReference_SelectionHandler_Generic.class.php...
error: while searching for:
      if ($vocabulary = taxonomy_vocabulary_machine_name_load($bundle)) {
        if ($terms = taxonomy_get_tree($vocabulary->vid, 0, NULL, TRUE)) {
          foreach ($terms as $term) {
            $options[$vocabulary->machine_name][$term->tid] = str_repeat('-', $term->depth) . check_plain($term->name);
          }
        }
      }

error: patch failed: plugins/selection/EntityReference_SelectionHandler_Generic.class.php:545
error: plugins/selection/EntityReference_SelectionHandler_Generic.class.php: patch does not apply