We are working in a patch for inline_entity_form #1526084: Abilty to add existing entities that uses entityreference's automplete behavior.

In node/entity creation form fails because in entityreference_autocomplete_callback there is a bug on $entity_id comprobation.

The patch I append fixes the problem.

CommentFileSizeAuthor
#13 entityreference-fixing_regression-1625188-13.patch965 bytesstefan.r
#11 entityreference-fixing_regression-1625188-11.patch869 bytesliuba
#4 entityreference-fixing_regresion-1625188-4.patch873 bytesmarcin.wosinek
#1 1706664-2.am_.patch916 bytesjherencia
#1 1706664-2.patch500 bytesjherencia

Comments

jherencia’s picture

jherencia commented
StatusFileSize
new 1706664-2.patch500 bytes
new 1706664-2.am_.patch916 bytes
marcin.wosinek’s picture

marcin.wosinek commented
Status: Needs review » Postponed (maintainer needs more info)

Could you post exact steps to reproduce this error? I've tried using autocomplete within inline_entity_form and it worked without patch.

jherencia’s picture

jherencia commented
Status: Postponed (maintainer needs more info) » Needs review

See the code and you'll find that in entityreference_autocomplete_callback $entity_id is set to '', not NULL as the comprobation expects. So even if in your installation of inline_entity_form works, it's a bug that probably will break something else.

Changing to needs review.

marcin.wosinek’s picture

marcin.wosinek commented
StatusFileSize
new entityreference-fixing_regresion-1625188-4.patch873 bytes

I've investigated code, and issue #1625188: Autocomplete widget failed to return any nodes for reference introduced 'NULL' as argument for non entity_id. So it looks like default value fell out of sync. Here's patch.

marcin.wosinek’s picture

marcin.wosinek commented

@jherencia could you check #4?

jherencia’s picture

jherencia commented
Status: Needs review » Reviewed & tested by the community

Yes, it works too :).

bojanz’s picture

bojanz commented

Note that Inline Entity Form doesn't need this patch since we went with using our own autocomplete callback after all.

jherencia’s picture

jherencia commented
Status: Reviewed & tested by the community » Fixed
rocketeerbkw’s picture

rocketeerbkw commented
Status: Fixed » Reviewed & tested by the community

#4 makes sense to me and should still be committed to entityreference even if inline_entity_form isn't broken anymore.

jherencia’s picture

jherencia commented

@rocketeerkbw

You are right, so RTBC.

liuba’s picture

liuba commented
StatusFileSize
new entityreference-fixing_regression-1625188-11.patch869 bytes

Here is the patch for the latest recommended version - 7.x-1.0

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 11: entityreference-fixing_regression-1625188-11.patch, failed testing.

stefan.r’s picture

stefan.r commented
Issue summary: View changes
StatusFileSize
new entityreference-fixing_regression-1625188-13.patch965 bytes

reroll

stefan.r’s picture

stefan.r commented
Status: Needs work » Reviewed & tested by the community
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #2532152: Plan for EntityReference 7.x-1.2 release
minoroffense’s picture

minoroffense commented
Status: Reviewed & tested by the community » Closed (works as designed)

I'm pretty sure this isn't relevant anymore. Plus the patch technically adds the word "NULL" and not the value NULL