Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
There are some minor errors in the coding standards
Comment | File | Size | Author |
---|---|---|---|
#6 | 2867823-6.patch | 1.4 KB | Pavan B S |
#3 | Before Review.png | 126.7 KB | krina.addweb |
#3 | After Review.png | 63.42 KB | krina.addweb |
#2 | 2867823-2.patch | 2.11 KB | Pavan B S |
Comments
Comment #2
Pavan B S CreditAttribution: Pavan B S at Valuebound commentedApplying the patch, please review.
Comment #3
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@Pavan B S, Thanks for the patch, I checked your patch using coder module & it cures error & warnings which show in coder review, I attached the after & before result of the review.
Comment #4
jojonaloha CreditAttribution: jojonaloha commentedThe second "error" reported by Coder is actually a false positive because
t()
is considered safe in this case because the variable is just a conditional.You could fix the false positive and avoid the unnecessary use of
check_plain()
by setting'#title' => t('Bundles'),
then after the end of the array,Comment #5
jojonaloha CreditAttribution: jojonaloha commentedComment #6
Pavan B S CreditAttribution: Pavan B S at Valuebound commentedRe applying the patch, as suggested in #4
Comment #8
quicksketchThanks! Committed to 7.x-1.x.
Comment #9
quicksketch