There are some minor errors in the coding standards

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Pavan B S created an issue. See original summary.

Pavan B S’s picture

Status: Active » Needs review
FileSize
2.11 KB

Applying the patch, please review.

krina.addweb’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
63.42 KB
126.7 KB

@Pavan B S, Thanks for the patch, I checked your patch using coder module & it cures error & warnings which show in coder review, I attached the after & before result of the review.

jojonaloha’s picture

The second "error" reported by Coder is actually a false positive because t() is considered safe in this case because the variable is just a conditional.

You could fix the false positive and avoid the unnecessary use of check_plain() by setting '#title' => t('Bundles'), then after the end of the array,

if ($target_type == 'node') {
  $form['settings']['entityreference_field']['target_bundles']['#title'] = t('Content types');
} 
jojonaloha’s picture

Status: Reviewed & tested by the community » Needs work
Pavan B S’s picture

Status: Needs work » Needs review
FileSize
1.4 KB

Re applying the patch, as suggested in #4

quicksketch’s picture

Thanks! Committed to 7.x-1.x.

quicksketch’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.