Make "Contextual links" work for views using Entityqueue

+1 Testing :)

+1 Having more testing.

Nice! The patch does make the contextual link appear for views, but the outside-in part doesn't seem to work.. should we remove it from the patch?

I'm testing on a default D8 install, so using the bartik theme.

I'm in with more testing ...... and automating the test.
I feel that the logic in the code is right,

Scenario: Check if content admins are able to see and click the contextual link to manage entitiyqueues which are attached to views when the Settings Tray outside-in module is not installed
Given that the "Settings Tray" module is not installed
When I go to a page which has a view display in it
And the view display is using an entity queue to sort entities
Then I will be able to see the "entityqueue" contextual link
When I click the "entityqueue" contextual link
And wait for the page to finish loading
Then I should see the list of queued entities
And I can add/reorder and remove entities.

Scenario: Check if content admins are able to see and click the contextual link to manage entityqueues which are attached to views when the Settings Tray outside-in module is installed
Given that the "Settings Tray" module is installed
When I go to a page which has a view display in it
And the view display is using an entity queue to sort entities
Then I will be able to see the "entityqueue" contextual link
When I click the "entityqueue" contextual link
And wait for AJAX to finish
Then I should see the list of queued entities in the "offcanvas" data dialog
And I can add/reorder/reverse and remove entities.

Spent some more time digging into this and I found out that the reason why I wasn't getting the right behavior with the settings tray is because contextual links are cached in the browser's session storage, and that's not cleared by the regular Drupal cache clearing mechanism.

Anyway, it does work nicely indeed, great work! I cleaned up the patch a little (see attached interdiff) and committed to 8.x-1.x. Thanks!

A preview of Drupal 8 "Outside-In" with Entity Queues.
This is done utilizing Sportsleague distribution and Entityqueue module with the Contextual Links patch.
https://www.youtube.com/watch?v=vr-AqQmLoGs

I get the "edit subqueue" option in the menu, but it doesn't open in a settings tray, it opens in a new page. I think it has to do with the fact that the module is now called Settings Tray (instead of Outside-in)?

That's a very good point. Can you try this patch?

Does the "data-ouside-in-edit" also have to be "data-settings-tray-edit" etc. ?

Indeed, and there's another instance that we need to update as well at the top of the function.

I had this one (off_canvas), but it still doesn't work.

Sorry, wrong file :)

I see I forgot to remove the "in" -_- Still doesn't work though.

It seems that the display for the entityqueue subqueue items field template has to be set to "default" instead of "minimal" ^^ It works now.

Nice, committed and pushed the followup patch to 8.x-1.x.

Thank you SvenVdv, Andrei I will use the patch until we have a new release for the entityqueue module.

Your work saves time.

Thanks for having this issue fixed after the Drupal core team had outside_in renamed to settings_tray in Drupal ^8.4.0 the folder and code!!

Having more testing ....

I have a view configured with a block display and a required entity queue relationship. I have settings tray module enabled. However I neither see the contextual links on the block wrapper, nor in the view wrapper. If I enter into the edit mode and edit the block. there are no options in the sidebar to edit the items in the entity queue.

What am I doing wrong here?

@jwilson3, it seems that we only show the contextual links when the view uses the entityqueue sort handler, but I don't see any good reason for that limitation so I wrote a patch for it here: #2957971: Show the 'Edit subqueue' contextual link even when the view does not use the entityqueue sort handler.

Can you test it and let me know if it works for you?