I noticed today that I no longer have access to edit fields or display fields in entityqueue. The tabs are gone and going to the page itself gives me a permissions error. It seems that there is a new field permission in core that needs to be checked. I don't have time to look into patching this right now but it removes a big part of the functionality of entityqueue. This seems to have become an issue as of Drupal 7.5.

Old callback

access_callback
entityqueue_queue_access | (Callback) entityqueue_queue_access();
access_arguments
a:2:{i:0;s:4:"view";i:1;i:4;}

New callback

access_callback
field_ui_admin_access | (Callback) field_ui_admin_access();
access_arguments
a:2:{i:0;s:24:"entityqueue_queue_access";i:1;a:2:{i:0;s:4:"view";i:1;i:4;}}

CommentFileSizeAuthor
#3 entityqueue_manage_fields_access_args-2791961-3.patch475 bytesaether
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

narquam created an issue. See original summary.

narquam’s picture

narquam CreditAttribution: narquam at Digital Bridge Solutions for American Medical Association commented

Traced the problem to entityqueue_entity_info(). Seems the access arguments are the issue, it needs to be changed and there are two options.
Original argument is 'access arguments' => array('view', 4)

Option 1: 'access arguments' => array('view', $name)
Option 2: 'access arguments' => array('view', '4')

foreach (entityqueue_queue_load_multiple() as $name => $queue) {
    $return['entityqueue_subqueue']['bundles'][$name] = array(
      'label' => $queue->label,
      'admin' => array(
        'path' => 'admin/structure/entityqueue/list/%entityqueue_queue',
        'real path' => 'admin/structure/entityqueue/list/' . $name,
        'bundle argument' => 4,
        'access callback' => 'entityqueue_queue_access',
        'access arguments' => array('view', $name),
      ),
    );
  }
aether’s picture

aether CreditAttribution: aether at Four Kitchens commented
FileSize
entityqueue_manage_fields_access_args-2791961-3.patch475 bytes

Patch for the fix documented in #2.

aether’s picture

aether CreditAttribution: aether at Four Kitchens commented
Version: 7.x-1.1 » 7.x-1.x-dev
Status: Active » Needs review
dasj19’s picture

dasj19 CreditAttribution: dasj19 commented

I used almost an entire working day until I found this issue, this needs to be released ASAP.
Another patch could be to use $queue:

'access arguments' => array('view', $queue),

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous at Cheeky Monkey Media commented

This patch works great - it provides proper access checks for the different queue pages.

  • amateescu committed 28ba6d6 on 7.x-1.x authored by aether 
    Issue #2791961 by aether, narquam, dasj19, rsmylski: Entityqueue no...
amateescu’s picture

amateescu CreditAttribution: amateescu for Pfizer, Inc. commented
Status: Needs review » Fixed

Thanks @aether for the patch and everyone for testing! Committed and pushed to 7.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.