Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hello,
Thank you very much for the module.
I think it will be very nice to be able to restrict the entity queue per bundles.
I will upload a patch that made that.
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff.txt | 17.7 KB | amateescu |
#6 | 2668220-6.patch | 18.92 KB | amateescu |
#4 | 2668220-4.patch | 12.15 KB | amateescu |
#3 | entityqueue-bundle_restriction-2668220-3.patch | 8.48 KB | Grimreaper |
#2 | entityqueue-bundle_restriction-2668220-2.patch | 6.96 KB | Grimreaper |
Comments
Comment #2
GrimreaperHere is the patch.
I think it will be nice to have the target bundles loaded with ajax (As on the config form of a search API index).
Comment #3
GrimreaperHere is a patch with the ajax handling.
Thanks for the review.
Comment #4
amateescu CreditAttribution: amateescu as a volunteer commentedWe shouldn't limit ourselves to only support the 'target_bundles' setting of the 'default' entity reference selection handler, we can fully expose the configuration of the 'items' entity reference field.
Here's a patch for that, for which I'd like to get some feedback on the user experience of the new configuration options before committing :)
Comment #5
JacineThank you for this patch!
I tested it this morning, and I'm having some issues with it, that may be user error. For some reason I'm not able to uninstall this module (which I was hoping to do, to make sure my findings were not a result of having both versions of these patches installed at some point).
First, some UX feedback. I was going to give you a patch for this, but I broke the AJAX handling and probably other stuff, so giving you a screenshot instead:
Summary of those changes:
Here are some of the questions/issues I found while testing:
I hope that's helpful. Thanks again for your work on this! It's much appreciated.
Comment #6
amateescu CreditAttribution: amateescu as a volunteer commentedThanks for the awesome review and suggestions! :)
Here's an updated patch that implements all the changes from 1 to 5.
About questions/issues:
Comment #7
amateescu CreditAttribution: amateescu as a volunteer commentedUpdating the title once again to reflect what's going on in the latest patch.
Comment #8
GrimreaperHello,
Thanks for the patches that go deeper than mine into the reference field parameters.
I will test its this weekend.
Comment #9
JacineThis is working perfectly, and it looks great too! Thanks again!
Comment #11
amateescu CreditAttribution: amateescu as a volunteer commentedGiven that the patch was already thoroughly tested by @Jacine and myself, I'm gonna go ahead and commit it.
Thanks everyone!
Comment #12
GrimreaperThanks, it works perfectly.
Comment #13
amateescu CreditAttribution: amateescu as a volunteer commentedNote that this patch caused two big problems in alpha3, so I also released alpha4 a few minutes ago to correct them.
Comment #14
Grimreaper#2676746: Update to Alpha3 causes fatal error and site won't load
Ok, I got the same problem when I tested the patch but as I had rebuilded my site (then applying the commit) to not have the data from my patches and then I didn't reproduce the bug I didn't mention it.